Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:Notification Bugs for Avatar, Room Conversion, and Room Name Change Events. #919

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

AyushKumar123456789
Copy link

Brief Title

Fix Notification Bugs for Avatar, Room Conversion, and Room Name Change Events.

Acceptance Criteria fulfillment

  • Notification for room avatar changes displays correct wording (e.g., "changed room avatar").
  • Notification for room-to-team and team-to-channel conversion displays appropriate messages (e.g., "converted #roomName to team" and "converted #roomName to channel").
  • Notification for room name change events displays the correct message and is not empty.

Fixes #918

Video/Screenshots

image

image

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-<pr_number> after approval. Contributors are requested to replace <pr_number> with the actual PR number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Incorrect Wording & Empty Message for Avatar/Room/Room Name Conversion Events.
1 participant