-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix travis builds so that they actually work again #66
Comments
What's not trivial is writing a complex role such as this and getting it to not fail when run in docker containers :'( I'll work on it soon |
The biggest problems seem to stem from the multitude of dependency systems used throughout the play. (i.e. if it's usually pip or npm dying on some external dependency mess up) Example:
This has absolutely nothing to do with even getting to the ansible playbook yet - it's failing on even installing ansible to run the damn playbook against itself! And, I had originally switched away from using the local package manager's version of ansible because it's oft not recommended to use those old versions (like say on debian or ubuntu LTS) because ansible is an extremely fast-moving project with lots of bug fixes. Since I'm not really sure where my target audience lies I tend to try and stay current with requiring recent (but not necessarily latest) versions of ansible. Probably going to drop support for the old Ubuntu version, maybe Deb 8 now that 9 is out... and we need to start testing on newer distros too, like Fedora 27, 28 ... I'd even like to get Rawhide in there, CentOS needs to be checked again 7.4 now. |
Hmm, maybe we can standardize the ansible version across containers by using Docker-In-Docker and pull in and use a reliable container with ansible pre-installed? |
I added a PR #108 which does provide a very simple, but working travis config for running the playbook inside docker. This one still need some improvement (e.g. additional tests at the end). Ubuntu 18.04 is also always failing because it does use the debian variables and i didn't figured out tonight why it does that. |
Makes validating Pull Request non trivial.
Either all jobs should pass or if failures are expected
allow_failures
used.The text was updated successfully, but these errors were encountered: