-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Improve clear cache #2869
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* video call window opens and load the video call in a webview
rodrigok
requested changes
Mar 27, 2024
rodrigok
approved these changes
Mar 27, 2024
rodrigok
requested changes
Mar 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing jira task
@jeanfbrito can you add images of the old menus and explain the reason for the change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://rocketchat.atlassian.net/browse/DSK-111
When a workspace with various instances of the server gets updated sometimes the Meteor's cache gets stuck in a version that is not available on that connected server making the user stuck in a loading loop.
To clear this cache we need to destroy IndexedDb and other storages that Meteor uses as cache control so the next reload will not try to execute old files from the cache.
We used to have a
Clear cache
action that only ignores the browser cache, but don't helps with the Meteor cache issue.So to fix this the user needed to use the
Clear storage data
that will destroy all the storage data and make the user need to log in again which could feel advanced or dangerous to be done by them.Users misunderstood it because the issue was a cache problem but the
Clear cache
doesn't work for this.So we are simplifying to a new option that will resolve when needed and yet be clearer to users who don't need to understand cache.
These are the changes:
Remove
Clear cache
andClear storage data
from server context menu.Add
Force reload
to server context menu and menubar on ViewA dialog will ask the user if the login session will be kept.
If
Keep login session
is clicked, all the cache storage will be destroyed but localStorage will be kept intact, keeping the session intact.If
Delete login session
is clicked, all the cache and localStorage will be destroyed and the user will need to login again.