Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(message-parser): Message parser issues #852

Merged
merged 9 commits into from
Oct 5, 2022
Merged

Conversation

gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Sep 27, 2022

Proposed changes (including videos or screenshots)

Feature branch that fixes several parsing issues mentioned in the issues below. It was also added test to check the desired and correct behavior

  • parser removes colons from timestamps
  • 👍 emoji parsed as a tel link when using the 👍 alias
  • Link containing an anchor does not get rendered
  • $ money amounts don't create links, but % still does
  • Message rendering of links containing : is still broken
  • Emoji will still be rendered inside URLs

Issue(s)

RocketChat/Rocket.Chat#26799
RocketChat/Rocket.Chat#26469
RocketChat/Rocket.Chat#26815
RocketChat/Rocket.Chat#26771
RocketChat/Rocket.Chat#26889
RocketChat/Rocket.Chat#23020

Further comments

hugocostadev and others added 2 commits October 4, 2022 11:31
* feat(fuselage): Adds wordbreak in Box Component (#853)

* Fixing URL/links parsing issues

* restoring files from base branch

* replacing backstick with single quotes

Co-authored-by: Douglas Fabris <[email protected]>
@gabriellsh gabriellsh merged commit 7ece520 into develop Oct 5, 2022
@gabriellsh gabriellsh deleted the parser-issues branch October 5, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants