Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: two factor resend mail and added a toast #6044

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

OtavioStasiak
Copy link
Contributor

@OtavioStasiak OtavioStasiak commented Dec 5, 2024

Proposed changes

When attempting to log in to an account with two-factor authentication enabled via email, the resend email button was not working. This function was checking the Redux store for the username or email, but since the user was not logged in, the store was empty. With my update, the app now retrieves the username or email entered by the customer on the LoginView instead and I added a toast to indicate for the user that the email was sent.

Issue(s)

https://rocketchat.atlassian.net/browse/NATIVE-733

How to test or reproduce

  • Open the app;
  • try to login on account with two factor;
  • click on resend email;

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@OtavioStasiak OtavioStasiak marked this pull request as ready for review December 5, 2024 16:08
@diegolmello diegolmello force-pushed the fix-two-factor-resend-mail-with-toast branch from c6f6d32 to 58dd2b9 Compare December 17, 2024 19:51
@diegolmello diegolmello merged commit a000522 into develop Dec 17, 2024
3 of 5 checks passed
@diegolmello diegolmello deleted the fix-two-factor-resend-mail-with-toast branch December 17, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants