Remove outdated cache busting parameter

RocketChat · Nov 12, 2024 · 2d8f570 · 2d8f570
1 parent 20763ac
commit 2d8f570
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/apps/meteor/app/emoji-custom/client/lib/emojiCustom.ts b/apps/meteor/app/emoji-custom/client/lib/emojiCustom.ts
@@ -1,7 +1,6 @@
 import type { IEmoji } from '@rocket.chat/core-typings';
 import { escapeRegExp } from '@rocket.chat/string-helpers';
 import { Meteor } from 'meteor/meteor';
-import { Session } from 'meteor/session';
 
 import { onLoggedIn } from '../../../../client/lib/loggedIn';
 import { emoji, removeFromRecent, replaceEmojiInRecent } from '../../../emoji/client';
@@ -19,15 +18,11 @@ const isSetNotNull = (fn: () => unknown) => {
 };
 
 const getEmojiUrlFromName = (name: string, extension: string, etag?: string) => {
-	if (name == null) {
+	if (!name) {
 		return;
 	}
 
-	const key = `emoji_random_${name}` as const;
-
-	const random = (Session as unknown as { keys: Record<string, any> }).keys[key] ?? 0;
-
-	return getURL(`/emoji-custom/${encodeURIComponent(name)}.${extension}?_dc=${random}${etag ? `&etag=${etag}` : ''}`);
+	return getURL(`/emoji-custom/${encodeURIComponent(name)}.${extension}${etag ? `?etag=${etag}` : ''}`);
 };
 
 export const deleteEmojiCustom = (emojiData: IEmoji) => {

diff --git a/apps/meteor/app/utils/client/getURL.ts b/apps/meteor/app/utils/client/getURL.ts
@@ -4,7 +4,13 @@ import { Info } from '../rocketchat.info';
 
 export const getURL = function (
 	path: string, // eslint-disable-next-line @typescript-eslint/naming-convention
-	params: Record<string, any> = {},
+	params: {
+		cdn?: boolean;
+		full?: boolean;
+		cloud?: boolean;
+		cloud_route?: string;
+		cloud_params?: Record<string, string>;
+	} = {},
 	cloudDeepLinkUrl?: string,
 	cacheKey?: boolean,
 ): string {