Merge pull request #6861 from RocketChat/fix-star-message

[FIX] start/unstar message
RocketChat · May 2, 2017 · 8dc691b · 8dc691b
2 parents 01211b1 + 0419f68
commit 8dc691b
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/packages/rocketchat-message-star/client/actionButton.js b/packages/rocketchat-message-star/client/actionButton.js
@@ -15,10 +15,11 @@ Meteor.startup(function() {
 			});
 		},
 		validation(message) {
-			if (RocketChat.models.Subscriptions.findOne({ rid: message.rid }) == null) {
+			if (RocketChat.models.Subscriptions.findOne({ rid: message.rid }) == null && RocketChat.settings.get('Message_AllowStarring')) {
 				return false;
 			}
-			return RocketChat.settings.get('Message_AllowStarring') && !message.starred;
+
+			return !_.findWhere(message.starred, {_id: Meteor.userId()});
 		},
 		order: 10
 	});
@@ -37,10 +38,11 @@ Meteor.startup(function() {
 			});
 		},
 		validation(message) {
-			if (RocketChat.models.Subscriptions.findOne({ rid: message.rid }) == null) {
+			if (RocketChat.models.Subscriptions.findOne({ rid: message.rid }) == null && RocketChat.settings.get('Message_AllowStarring')) {
 				return false;
 			}
-			return RocketChat.settings.get('Message_AllowStarring') && message.starred;
+
+			return Boolean(_.findWhere(message.starred, {_id: Meteor.userId()}));
 		},
 		order: 10
 	});