Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW][API] Endpoint integration.update #13618

Merged
merged 6 commits into from
Jun 19, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 58 additions & 0 deletions app/api/server/v1/integrations.js
Original file line number Diff line number Diff line change
Expand Up @@ -190,3 +190,61 @@ API.v1.addRoute('integrations.get', { authRequired: true }, {
});
},
});

API.v1.addRoute('integrations.update', { authRequired: true }, {
put() {
check(this.bodyParams, Match.ObjectIncluding({
type: String,
name: String,
enabled: Boolean,
username: String,
urls: Match.Maybe([String]),
channel: String,
event: Match.Maybe(String),
triggerWords: Match.Maybe([String]),
alias: Match.Maybe(String),
avatar: Match.Maybe(String),
emoji: Match.Maybe(String),
token: Match.Maybe(String),
scriptEnabled: Boolean,
script: Match.Maybe(String),
targetChannel: Match.Maybe(String),
integrationId: Match.Maybe(String),
target_url: Match.Maybe(String),
}));

let integration;
switch (this.bodyParams.type) {
case 'webhook-outgoing':
if (this.bodyParams.target_url) {
integration = Integrations.findOne({ urls: this.bodyParams.target_url });
} else if (this.bodyParams.integrationId) {
integration = Integrations.findOne({ _id: this.bodyParams.integrationId });
}

if (!integration) {
return API.v1.failure('No integration found.');
}

Meteor.call('updateOutgoingIntegration', integration._id, this.bodyParams);

return API.v1.success({
integration: Integrations.findOne({ _id: integration._id }),
});
case 'webhook-incoming':
integration = Integrations.findOne({ _id: this.bodyParams.integrationId });

if (!integration) {
return API.v1.failure('No integration found.');
}

Meteor.call('updateIncomingIntegration', integration._id, this.bodyParams);

return API.v1.success({
integration: Integrations.findOne({ _id: integration._id }),
});
default:
return API.v1.failure('Invalid integration type.');
}
},
});
42 changes: 42 additions & 0 deletions tests/end-to-end/api/07-incoming-integrations.js
Original file line number Diff line number Diff line change
Expand Up @@ -348,6 +348,48 @@ describe('[Incoming Integrations]', function() {
});
});

describe('[/integrations.update]', () => {
it('should update an integration by id and return the new data', (done) => {
request.put(api('integrations.update'))
.set(credentials)
.send({
type: 'webhook-incoming',
name: 'Incoming test updated',
enabled: true,
alias: 'test updated',
username: 'rocket.cat',
scriptEnabled: true,
channel: '#general',
integrationId: integration._id,
})
.expect('Content-Type', 'application/json')
.expect(200)
.expect((res) => {
expect(res.body).to.have.property('success', true);
expect(res.body).to.have.property('integration');
expect(res.body.integration._id).to.be.equal(integration._id);
expect(res.body.integration.name).to.be.equal('Incoming test updated');
expect(res.body.integration.alias).to.be.equal('test updated');
})
.end(done);
});

it('should have integration updated on subsequent gets', (done) => {
request.get(api(`integrations.get?integrationId=${ integration._id }`))
.set(credentials)
.expect('Content-Type', 'application/json')
.expect(200)
.expect((res) => {
expect(res.body).to.have.property('success', true);
expect(res.body).to.have.property('integration');
expect(res.body.integration._id).to.be.equal(integration._id);
expect(res.body.integration.name).to.be.equal('Incoming test updated');
expect(res.body.integration.alias).to.be.equal('test updated');
})
.end(done);
});
});

describe('[/integrations.remove]', () => {
it('should return an error when the user DOES NOT have the permission "manage-incoming-integrations" to remove an incoming integration', (done) => {
updatePermission('manage-incoming-integrations', []).then(() => {
Expand Down