-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMPROVE] User gets UI feedback when message is pinned or unpinned #16056
Conversation
@ggazzo Would you please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some reviews about the error messages. Thanks!
@MartinSchoeler I have done the requested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now. Thanks for the contribution!
5e5db2c
…users_and_rooms * 'develop' of github.com:RocketChat/Rocket.Chat: (29 commits) [FIX] 2FA not showing codes for Spanish translation (#17378) [NEW] [ENTERPRISE] Restrict the permissions configuration for guest users (#17333) [NEW] Federation event for when users left rooms (#17091) [FIX] CSV Importer fails when there are no users to import (#16790) Import slack's mpims as direct rooms instead of private groups (#17206) [FIX] SAML Idp Initiated Logout Error (#17324) [NEW] Better Push and Email Notification logic (#17357) [NEW] Error page when browser is not supported (#17372) [NEW] [ENTERPRISE] Omnichannel queue priorities (#17141) [IMPROVE] Change the SAML metadata order to conform to XSD specification (#15488) [IMPROVE] Filter markdown in notifications (#9995) [IMPROVE] User gets UI feedback when message is pinned or unpinned (#16056) Remove set as alias setting (#16343) [IMPROVE] Add `file-title` and `file-desc` as new filter tag options on message search (#16858) [NEW] Add ability to set tags in the Omnichannel room closing dialog (#17254) [FIX] Show active admin and user account menu item (#17047) [NEW] [ENTERPRISE] Allows to set a group of departments accepted for forwarding chats (#17335) [FIX] Prevent user from getting stuck on login, if there is some bad fname (#17331) [FIX] Remove properties from users.info response (#17238) Bump version to 3.1.1 ...
Closes #13869
This PR is continuation of the closed PR #13870 where some changes were requested.
When message is pinned.
![Screenshot from 2019-03-23 14-19-54](https://user-images.githubusercontent.com/43786728/54866146-67000b00-4d96-11e9-95b3-2e0b8b4c1380.png)
When message is unpinned.
![Screenshot from 2019-03-23 14-20-05](https://user-images.githubusercontent.com/43786728/54866145-67000b00-4d96-11e9-9855-7818cf948e61.png)