Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE] User gets UI feedback when message is pinned or unpinned #16056

Merged
merged 5 commits into from
Apr 21, 2020
Merged

[IMPROVE] User gets UI feedback when message is pinned or unpinned #16056

merged 5 commits into from
Apr 21, 2020

Conversation

ashwaniYDV
Copy link
Contributor

@ashwaniYDV ashwaniYDV commented Dec 24, 2019

Closes #13869

This PR is continuation of the closed PR #13870 where some changes were requested.

When message is pinned.
Screenshot from 2019-03-23 14-19-54

When message is unpinned.
Screenshot from 2019-03-23 14-20-05

@ashwaniYDV
Copy link
Contributor Author

@ggazzo Would you please review.

ggazzo
ggazzo previously approved these changes Feb 3, 2020
@ggazzo ggazzo added this to the 3.0.0 milestone Feb 3, 2020
@ggazzo ggazzo requested a review from MartinSchoeler February 3, 2020 13:07
@ggazzo ggazzo added the ui/ux label Feb 3, 2020
Copy link
Member

@MartinSchoeler MartinSchoeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some reviews about the error messages. Thanks!

app/message-pin/client/pinMessage.js Outdated Show resolved Hide resolved
app/message-pin/client/pinMessage.js Outdated Show resolved Hide resolved
@ashwaniYDV
Copy link
Contributor Author

@MartinSchoeler I have done the requested changes.

zdumitru
zdumitru previously approved these changes Feb 5, 2020
MartinSchoeler
MartinSchoeler previously approved these changes Feb 5, 2020
Copy link
Member

@MartinSchoeler MartinSchoeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now. Thanks for the contribution!

@engelgabriel engelgabriel modified the milestones: 3.0.0, 3.1.0 Mar 17, 2020
@ashwaniYDV ashwaniYDV dismissed stale reviews from MartinSchoeler and zdumitru via 5e5db2c March 19, 2020 11:26
@CLAassistant
Copy link

CLA assistant check
All committers have signed the CLA.

@engelgabriel engelgabriel modified the milestones: 3.1.0, 3.2.0 Apr 20, 2020
@rodrigok rodrigok changed the title User gets UI feedback when message is pinned or unpinned [IMPROVE] User gets UI feedback when message is pinned or unpinned Apr 21, 2020
@rodrigok rodrigok merged commit 2e0e457 into RocketChat:develop Apr 21, 2020
gabriellsh added a commit that referenced this pull request Apr 22, 2020
…users_and_rooms

* 'develop' of github.com:RocketChat/Rocket.Chat: (29 commits)
  [FIX] 2FA not showing codes for Spanish translation (#17378)
  [NEW] [ENTERPRISE] Restrict the permissions configuration for guest users  (#17333)
  [NEW] Federation event for when users left rooms (#17091)
  [FIX] CSV Importer fails when there are no users to import (#16790)
  Import slack's mpims as direct rooms instead of private groups (#17206)
  [FIX] SAML Idp Initiated Logout Error (#17324)
  [NEW] Better Push and Email Notification logic (#17357)
  [NEW] Error page when browser is not supported (#17372)
  [NEW] [ENTERPRISE] Omnichannel queue priorities (#17141)
  [IMPROVE] Change the SAML metadata order to conform to XSD specification (#15488)
  [IMPROVE] Filter markdown in notifications (#9995)
  [IMPROVE] User gets UI feedback when message is pinned or unpinned (#16056)
  Remove set as alias setting (#16343)
  [IMPROVE] Add `file-title` and `file-desc` as new filter tag options on message search (#16858)
  [NEW]  Add ability to set tags in the Omnichannel room closing dialog (#17254)
  [FIX] Show active admin and user account menu item (#17047)
  [NEW] [ENTERPRISE] Allows to set a group of departments accepted for forwarding chats (#17335)
  [FIX] Prevent user from getting stuck on login, if there is some bad fname (#17331)
  [FIX] Remove properties from users.info response (#17238)
  Bump version to 3.1.1
  ...
@sampaiodiego sampaiodiego mentioned this pull request Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No user feedback when meassage is pinned or unpinned
7 participants