Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] User can resend email verification if email is invalid or is empty #16095

Merged
merged 5 commits into from
Jun 19, 2020
Merged

[FIX] User can resend email verification if email is invalid or is empty #16095

merged 5 commits into from
Jun 19, 2020

Conversation

ashwaniYDV
Copy link
Contributor

@ashwaniYDV ashwaniYDV commented Dec 28, 2019 •
edited
Loading

Closes #16066

emailllll

@ashwaniYDV ashwaniYDV changed the title [FIX] User cannot resend email verification even if email is not correct or is empty [FIX] User cannot resend email verification if email is not correct or is empty Dec 28, 2019
@ashwaniYDV ashwaniYDV changed the title [FIX] User cannot resend email verification if email is not correct or is empty [FIX] User cannot resend email verification if email is invalid or is empty Dec 28, 2019
@ashwaniYDV
Copy link
Contributor Author

@ggazzo Would you please review.

dudizilla
dudizilla previously requested changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@dudizilla dudizilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taking into account the current behaviour, we should only let the user resend his email verification if changes to it have been saved. Basically we want the button to be disabled until the Database email match the input.

@ashwaniYDV
Copy link
Contributor Author

Taking into account the current behaviour, we should only let the user resend his email verification if changes to it have been saved. Basically we want the button to be disabled until the Database email match the input.

@mariaeduardacunha
I have done the requested changes and modified my issue.
I have added the functionality to resend email only if entered email matches the database email.

@ashwaniYDV
Copy link
Contributor Author

@gabriellsh Please review

@CLAassistant
Copy link

CLA assistant check
All committers have signed the CLA.

@rodrigok rodrigok changed the title [FIX] User cannot resend email verification if email is invalid or is empty [FIX] User can resend email verification if email is invalid or is empty May 30, 2020
@rodrigok rodrigok added this to the 3.4.0 milestone May 30, 2020
@rodrigok rodrigok merged commit 1b10d80 into RocketChat:develop Jun 19, 2020
@sampaiodiego sampaiodiego mentioned this pull request Jun 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigok rodrigok rodrigok approved these changes

@dudizilla dudizilla dudizilla left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

[BUG] User can resend email verification even if it does not matches database email
4 participants
@ashwaniYDV @CLAassistant @rodrigok @dudizilla