Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo "You aren't part of any channel yet" #17498

Merged
merged 1 commit into from
May 20, 2020
Merged

Fix typo "You aren't part of any channel yet" #17498

merged 1 commit into from
May 20, 2020

Conversation

huzaifahj
Copy link
Contributor

Closes #ISSUE_NUMBER

@CLAassistant
Copy link

CLAassistant commented Apr 30, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

ndroo
ndroo approved these changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@ndroo ndroo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good by me.

@engelgabriel
Copy link
Member

I am not sure this is even wrong or not. According to https://english.stackexchange.com/questions/112996/any-followed-by-singular-or-plural-countable-nouns seems that both would be correct in this case.

@engelgabriel engelgabriel added this to the 3.3.0 milestone May 9, 2020
@huzaifahj
Copy link
Contributor Author

They are, but context matters. Users are much more likely to be part of several channels. Rather than only be added to one and restricted to it.

@rodrigok rodrigok changed the title [FIX] Fix typo Fix typo May 20, 2020
@rodrigok rodrigok changed the title Fix typo Fix typo "You aren't part of any channel yet" May 20, 2020
@rodrigok rodrigok self-assigned this May 20, 2020
@rodrigok rodrigok merged commit c5016cf into RocketChat:develop May 20, 2020
ggazzo added a commit that referenced this pull request May 21, 2020
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into regr…
3a81933 
…ession/status-color

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [IMPROVE] Remove index files from action-links, accounts and assets (#17607)
  [FIX] Remove a non working setting "Notification Duration" (#15737)
  Update Apps-Engine version (#17706)
  Regression: Click to join button not working (#17705)
  [IMPROVE] Always shows the exact match first on user's and room's autocomplete for mentions and on sidebar search (#16394)
  [NEW] API endpoint to fetch Omnichannel's room transfer history (#17694)
  Fix typo "You aren't part of any channel yet" (#17498)
  [IMPROVE] Display status information in the Omnichannel Agents list (#17701)
  [NEW] Option to remove users from RocketChat if not found in Crowd (#17619)
  [FIX] Elements of  "Personal Access Tokens" section out of alignment and unusable on very small screens (#17129)
  Regression: Integrations edit/history crashing (#17702)
  [FIX] Allow owners to react inside broadcast channels (#17687)
  Regression: User edit form missing fields (#17699)
  [FIX] Default filters on Omnichannel Current Chats screen not showing on first load (#17522)
  Update Helper.js (#17700)
  [FIX] UI KIT Modal Width (#17697)
  Update Contributing Guide (#17653)
ggazzo added a commit to ritwizsinha/Rocket.Chat that referenced this pull request May 21, 2020
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into pr/1…
0ab7301 
…6537-ritwizsinha-Issue#16499

* 'develop' of github.com:RocketChat/Rocket.Chat: (428 commits)
  Regression: Status presence  color (RocketChat#17707)
  [IMPROVE] Remove index files from action-links, accounts and assets (RocketChat#17607)
  [FIX] Remove a non working setting "Notification Duration" (RocketChat#15737)
  Update Apps-Engine version (RocketChat#17706)
  Regression: Click to join button not working (RocketChat#17705)
  [IMPROVE] Always shows the exact match first on user's and room's autocomplete for mentions and on sidebar search (RocketChat#16394)
  [NEW] API endpoint to fetch Omnichannel's room transfer history (RocketChat#17694)
  Fix typo "You aren't part of any channel yet" (RocketChat#17498)
  [IMPROVE] Display status information in the Omnichannel Agents list (RocketChat#17701)
  [NEW] Option to remove users from RocketChat if not found in Crowd (RocketChat#17619)
  [FIX] Elements of  "Personal Access Tokens" section out of alignment and unusable on very small screens (RocketChat#17129)
  Regression: Integrations edit/history crashing (RocketChat#17702)
  [FIX] Allow owners to react inside broadcast channels (RocketChat#17687)
  Regression: User edit form missing fields (RocketChat#17699)
  [FIX] Default filters on Omnichannel Current Chats screen not showing on first load (RocketChat#17522)
  Update Helper.js (RocketChat#17700)
  [FIX] UI KIT Modal Width (RocketChat#17697)
  Update Contributing Guide (RocketChat#17653)
  LingoHub based on develop (RocketChat#17693)
  [NEW] Added custom fields to Add/Edit user (RocketChat#17681)
  ...
This was referenced May 28, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engelgabriel engelgabriel engelgabriel approved these changes

@ndroo ndroo ndroo approved these changes

@rodrigok rodrigok rodrigok approved these changes

Assignees

@rodrigok rodrigok

Labels
None yet
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@huzaifahj @CLAassistant @engelgabriel @rodrigok @ndroo