Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chatpal: limit results to current room #17718

Merged
merged 5 commits into from
Jun 17, 2020
Merged

Chatpal: limit results to current room #17718

merged 5 commits into from
Jun 17, 2020

Conversation

mrsimpson
Copy link
Collaborator

@mrsimpson mrsimpson commented May 21, 2020 •
edited
Loading

Proposed changes

Allow users to restrict the search results to the room which is currently opened.

Issue(s)

no issue created yet, only verbalized by @geekgonecrazy

How to test or reproduce

Create messages in two rooms with the same word in it.
Then switch to one room and search for the word.
Based upon your result selection, only the message in the room selected shall be returned.

Screenshots

Bildschirmvideo-aufnehmen-2020-0

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Adds an option to Chatpal Search to limit results to the current room searched from

Further comments

@mrsimpson
Copy link
Collaborator Author

While implementing this feature, I also noticed two nasty bugs rendering Chatpal unusable:

  • Scrolling was not possible at all
  • The user's avatars were not displayed

Since they ware so nasty but easy to fix, I did this within this PR. Please accept it though I know I could have created three of them.

@geekgonecrazy
Copy link
Contributor

IMO I consider this a fix. Since it was unusable by most with out this.

But could be argued new feature too. :)

@rodrigok rodrigok added this to the 3.4.0 milestone May 26, 2020
@rodrigok rodrigok merged commit 867a763 into RocketChat:develop Jun 17, 2020
ggazzo added a commit that referenced this pull request Jun 18, 2020
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into new/…
0114c3a 
…apps_rewrite* 'develop' of github.com:RocketChat/Rocket.Chat: (28 commits) [IMPROVE] Performance editing Admin settings (#17916)  [IMPROVE] React hooks lint rules (#17941)  [FIX] StreamCast stream to server only streamers (#17942)  [FIX] Profile save button not activates properly when changing the username field (#16541)  [FIX] Outgoing webhook: Excessive spacing between trigger words (#17830)  [FIX] Links being escaped twice leading to visible encoded characters (#16481)  [NEW][API] New endpoints to manage User Custom Status `custom-user-status.create`, custom-user-status.delete` and `custom-user-status.update` (#16550)  [FIX] Message action popup doesn't adjust itself on screen resize (#16508)  [FIX] Not possible to translate the label of custom fields in user's Info (#15595)  [FIX] Close the user info context panel does not navigate back to the user's list (#14085)  [FIX] Missing pinned icon indicator for messages pinned (#16448)  Chatpal: limit results to current room (#17718)  Do not build Docker image for fork PRs (#17370)  [IMPROVE] Use REST for DDP calls by default (#17934)  [IMPROVE] Add rate limiter to UiKit endpoints (#17859)  LingoHub based on develop (#17796)  [IMPROVE] Change default upload settings to only block SVG files (#17933)  Update Dockerfile to not depend on custom base image (#17802)  [IMPROVE][Performance] Add new database indexes to improve data query performance (#17839)  [FIX] Undesirable message updates after user saving profile (#17930)  ...
gabriellsh added a commit that referenced this pull request Jun 18, 2020
@gabriellsh
Merge branch 'new/apps_rewrite' of github.com:RocketChat/Rocket.Chat …
cc80513 
…into new/apps_rewrite_local

* 'new/apps_rewrite' of github.com:RocketChat/Rocket.Chat: (30 commits)
  Sort imports
  Move sidebar items registration
  Embed useMenuOptions into AppMenu
  Fix route redirection
  Fix lint errors
  Fix infinite loop in CodeSettingInput
  Fix spacing in What Is It page
  [IMPROVE] Performance editing Admin settings (#17916)
  [IMPROVE] React hooks lint rules (#17941)
  [FIX] StreamCast stream to server only streamers (#17942)
  [FIX] Profile save button not activates properly when changing the username field (#16541)
  [FIX] Outgoing webhook: Excessive spacing between trigger words (#17830)
  [FIX] Links being escaped twice leading to visible encoded characters (#16481)
  [NEW][API] New endpoints to manage User Custom Status `custom-user-status.create`, custom-user-status.delete` and `custom-user-status.update` (#16550)
  [FIX] Message action popup doesn't adjust itself on screen resize (#16508)
  [FIX] Not possible to translate the label of custom fields in user's Info (#15595)
  [FIX] Close the user info context panel does not navigate back to the user's list (#14085)
  [FIX] Missing pinned icon indicator for messages pinned (#16448)
  Chatpal: limit results to current room (#17718)
  Do not build Docker image for fork PRs (#17370)
  ...
ggazzo added a commit that referenced this pull request Jun 18, 2020
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into feat…
1eb303a 
…/new-threads

* 'develop' of github.com:RocketChat/Rocket.Chat: (23 commits)
  [FIX] Typo "coorosponding" (#17840)
  Regression: Infinite loop in CodeSettingInput (#17949)
  [NEW][ENTERPRISE] Download engagement data (#17920)
  [FIX] Hide system message add/remove owner  (#17938)
  [IMPROVE] Performance editing Admin settings (#17916)
  [IMPROVE] React hooks lint rules (#17941)
  [FIX] StreamCast stream to server only streamers (#17942)
  [FIX] Profile save button not activates properly when changing the username field (#16541)
  [FIX] Outgoing webhook: Excessive spacing between trigger words (#17830)
  [FIX] Links being escaped twice leading to visible encoded characters (#16481)
  [NEW][API] New endpoints to manage User Custom Status `custom-user-status.create`, custom-user-status.delete` and `custom-user-status.update` (#16550)
  [FIX] Message action popup doesn't adjust itself on screen resize (#16508)
  [FIX] Not possible to translate the label of custom fields in user's Info (#15595)
  [FIX] Close the user info context panel does not navigate back to the user's list (#14085)
  [FIX] Missing pinned icon indicator for messages pinned (#16448)
  Chatpal: limit results to current room (#17718)
  Do not build Docker image for fork PRs (#17370)
  [IMPROVE] Use REST for DDP calls by default (#17934)
  [IMPROVE] Add rate limiter to UiKit endpoints (#17859)
  LingoHub based on develop (#17796)
  ...
@sampaiodiego sampaiodiego mentioned this pull request Jun 30, 2020
Merged
@mrsimpson mrsimpson deleted the chatpal-limit-to-room branch December 7, 2020 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekgonecrazy geekgonecrazy geekgonecrazy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mrsimpson @geekgonecrazy @rodrigok