Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submit a payload to the release service when a release happens #17775

Merged
merged 1 commit into from
May 28, 2020
Merged

Submit a payload to the release service when a release happens #17775

merged 1 commit into from
May 28, 2020

Conversation

graywolf336
Copy link
Contributor

@graywolf336 graywolf336 commented May 28, 2020 •
edited
Loading

Proposed changes

We are switching up our internal release service and in order to improve the efficiency of it we are now expecting a payload to be sent to the release service so we don't have to make multiple round trip calls. This PR changes the update-release.sh script to provide the said payload.

How to test or reproduce

Run the new release service locally (private repository), set the expected variables to values they would be, and then run the changed command.

Environmental variables are set here:

Rocket.Chat/.github/workflows/build_and_test.yml

Lines 368 to 397 in 0d2723f

env:
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
GPG_PASSWORD: ${{ secrets.GPG_PASSWORD }}
REDHAT_REGISTRY_PID: ${{ secrets.REDHAT_REGISTRY_PID }}
REDHAT_REGISTRY_KEY: ${{ secrets.REDHAT_REGISTRY_KEY }}
UPDATE_TOKEN: ${{ secrets.UPDATE_TOKEN }}
run: |
if [[ '${{ github.event_name }}' = 'release' ]]; then
export CIRCLE_TAG="${GITHUB_REF#*tags/}"
else
export CIRCLE_BRANCH="${GITHUB_REF#*heads/}"
fi;
export CIRCLE_TAG=${CIRCLE_TAG:=}
export CIRCLE_SHA1=$GITHUB_SHA
export CIRCLE_BUILD_NUM=$GITHUB_SHA
aws s3 cp s3://rocketchat/sign.key.gpg .circleci/sign.key.gpg
source .circleci/setartname.sh
source .circleci/setdeploydir.sh
bash .circleci/setupsig.sh
bash .circleci/namefiles.sh
aws s3 cp $ROCKET_DEPLOY_DIR/ s3://download.rocket.chat/build/ --recursive
bash .circleci/update-releases.sh
# bash .circleci/snap.sh
bash .circleci/redhat-registry.sh

@rodrigok rodrigok changed the title [OTHER] Submit a payload to the release service when a release happens Submit a payload to the release service when a release happens May 28, 2020
@geekgonecrazy geekgonecrazy marked this pull request as ready for review May 28, 2020 22:29
@geekgonecrazy geekgonecrazy merged commit cae6aeb into develop May 28, 2020
@geekgonecrazy geekgonecrazy deleted the new-release-service branch May 28, 2020 22:29
gabriellsh added a commit that referenced this pull request Jun 1, 2020
@gabriellsh
Merge branch 'new/apps_rewrite' of github.com:RocketChat/Rocket.Chat …
1658818 
…into new/apps_rewrite

* 'new/apps_rewrite' of github.com:RocketChat/Rocket.Chat: (31 commits)
  Readme: Update Raspberry Pi 2 to Pi 4 (#17031)
  [NEW] Accept variable `#{userdn}` on LDAP group filter (#16273)
  [FIX] Spotify embed link opens in same tab (#13637)
  [FIX] Markdown links not accepting URLs with parentheses (#13605)
  [NEW][API] Endpoint `settings.addCustomOAuth` to create Custom OAuth services (#14912)
  [IMPROVE] Make the implementation of custom code easier by having placeholders for a custom folder (#15106)
  [NEW] Skip Export Operations that haven't been updated in over a day (#16135)
  [NEW] Highlight matching words in message search results (#16166)
  [FIX] Set `x-content-type-options: nosniff` header (#16232)
  [FIX] Disabling `Json Web Tokens protection to file uploads` disables the File Upload protection entirely (#16262)
  Fixes some italian word (#14008)
  Submit a payload to the release service when a release happens (#17775)
  Bump version to 3.4.0-develop
  Bump version to 3.3.0
  Bump version to 3.3.0-rc.4
  Bump version to 3.3.0-rc.3
  Bump version to 3.3.0-rc.2
  Bump version to 3.3.0-rc.1
  Bump version to 3.3.0-rc.0
  [FIX] Slack importer Link handling (#17595)
  ...
shedoev added a commit to sibdigital/rgrt that referenced this pull request Jun 2, 2020
@shedoev
Merge branch 'develop' of https://github.com/RocketChat/Rocket.Chat i…
df8121e 
…nto develop

* 'develop' of https://github.com/RocketChat/Rocket.Chat: (83 commits)
  Fix invalid develop payload to release service (RocketChat#17799)
  Readme: Update Raspberry Pi 2 to Pi 4 (RocketChat#17031)
  [NEW] Accept variable `#{userdn}` on LDAP group filter (RocketChat#16273)
  [FIX] Spotify embed link opens in same tab (RocketChat#13637)
  [FIX] Markdown links not accepting URLs with parentheses (RocketChat#13605)
  [NEW][API] Endpoint `settings.addCustomOAuth` to create Custom OAuth services (RocketChat#14912)
  [IMPROVE] Make the implementation of custom code easier by having placeholders for a custom folder (RocketChat#15106)
  [NEW] Skip Export Operations that haven't been updated in over a day (RocketChat#16135)
  [NEW] Highlight matching words in message search results (RocketChat#16166)
  [FIX] Set `x-content-type-options: nosniff` header (RocketChat#16232)
  [FIX] Disabling `Json Web Tokens protection to file uploads` disables the File Upload protection entirely (RocketChat#16262)
  Fixes some italian word (RocketChat#14008)
  Submit a payload to the release service when a release happens (RocketChat#17775)
  Bump version to 3.4.0-develop
  Bump version to 3.3.0
  Bump version to 3.3.0-rc.4
  Regression: Fix Unread bar design (RocketChat#17750)
  Regression: Adjusting spaces between OAuth login buttons (RocketChat#17745)
  Improved thread margins for clarity
  Bump version to 3.3.0-rc.3
  ...

� Conflicts:
�	app/theme/client/imports/general/variables.css
�	app/ui-sidenav/client/sideNav.html
ggazzo added a commit that referenced this pull request Jun 3, 2020
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into feat…
e38a519 
…/new-threads* 'develop' of github.com:RocketChat/Rocket.Chat: (54 commits) Submit a payload to the release service when a release happens (#17775)  Regression: Fix Unread bar design (#17750)  Regression: Adjusting spaces between OAuth login buttons (#17745)  Improved thread margins for clarity  Regression: Scroll on admin user info (#17711)  Regression: Removed status border on mentions list (#17741)  Regression: Force unread-rooms bar to appears over the room list (#17728)  [NEW][APPS-ENGINE] Essentials mechanism (#17656)  Regression: Fix error preventing creation of group DMs (#17726)  [FIX] SAML IDP initiated logout error (#17482)  Regression: Threads list was fetching all threads (#17716)  Regression: Add missing return to afterSaveMessage callbacks (#17715)  [FIX] Missing dropdown to select custom status color on user's profile (#16537)  [FIX] Password reset/change accepting current password as new password (#16331)  [NEW][ENTERPRISE] Support Omnichannel conversations auditing (#17692)  Upgrade Livechat Widget version to 1.5.0 (#17710)  [FIX] Can't click on room's actions menu of sidebar list when in search mode (#16548)  [NEW][ENTERPRISE] Support for custom Livechat registration form fields (#17581)  Update Fuselage version (#17708)  [NEW][ENTERPRISE] Omnichannel Last-Chatted Agent Preferred option (#17666)  ...
sampaiodiego pushed a commit that referenced this pull request Jun 10, 2020
@graywolf336 @sampaiodiego
Submit a payload to the release service when a release happens (#17775)
bf9421d
@sampaiodiego sampaiodiego mentioned this pull request Jun 10, 2020
Merged
@sampaiodiego sampaiodiego mentioned this pull request Jun 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekgonecrazy geekgonecrazy geekgonecrazy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@graywolf336 @geekgonecrazy