Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Omnichannel close room callback returning promise #18102

Merged
merged 2 commits into from
Jul 1, 2020
Merged

[FIX] Omnichannel close room callback returning promise #18102

merged 2 commits into from
Jul 1, 2020

Conversation

renatobecker
Copy link
Contributor

@renatobecker renatobecker commented Jul 1, 2020 •
edited
Loading

Proposed changes

After this change (release 3.4) one of the callbacks is returning a promise instead of a regular value, so the callback handler needs to handle it properly.

How to test or reproduce

  • Setup the Omnichannel webhooks
  • Select Send Request on Chat Close option
  • Start an Omnichannel conversation
  • Close the conversation

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

@renatobecker renatobecker added this to the 3.4.1 milestone Jul 1, 2020
@renatobecker renatobecker merged commit 17bae05 into develop Jul 1, 2020
@renatobecker renatobecker deleted the omnichannel/fix-callback-returning-promise branch July 1, 2020 18:09
gabriellsh added a commit that referenced this pull request Jul 1, 2020
@gabriellsh
Merge branch 'rewrite/accounts' of github.com:RocketChat/Rocket.Chat …
f78282b 
…into new/rewrite_account_profile

* 'rewrite/accounts' of github.com:RocketChat/Rocket.Chat:
  [FIX] Avatar ETag missing from User (#18109)
  Handle callback returning promise. (#18102)
  [FIX] Not possible to read encrypted messages after disable E2E on channel level (#18101)
sampaiodiego pushed a commit that referenced this pull request Jul 2, 2020
@renatobecker @sampaiodiego
Handle callback returning promise. (#18102)
5787844
@sampaiodiego sampaiodiego mentioned this pull request Jul 2, 2020
Merged
@renatobecker renatobecker mentioned this pull request Jul 3, 2020
Closed
ggazzo added a commit that referenced this pull request Jul 28, 2020
@sampaiodiego @ggazzo
@dudizilla @gabriellsh @renatobecker @rodrigok @paulobernardoaf @Densik @omarchehab98 @pierre-lehnen-rc
Merge master into develop & Set version to 3.6.0-develop (#18401)
9b49a44 
* [FIX] Jitsi opening twice (#18111)

* [FIX] "Add reaction" icon missing when the viewport size is smaller than 500px (#18110)

* [FIX] Avatar ETag missing from User (#18109)

* Handle callback returning promise. (#18102)

* [FIX] Not possible to read encrypted messages after disable E2E on channel level (#18101)

* [FIX] The livechat agent activity monitor wasn't being initialised because due to an internal error (#18090)

* [FIX] Email notifications were still being sent for online users (#18088)

* Bump version to 3.4.1

* [FIX] App details returns to apps table, instead of previous page (#18080)

* [FIX] Cannot open admin when server uses ROOT_URL with subpath (#18105) (#18147)

* [FIX] Old Data Migrations breaking upgrades (#18185)

* [FIX] Application not loading due to reverse proxy decoding API calls unnecessarily (#18222)

* [FIX] SAML login crashing when receiving an array of roles (#18224)

* [FIX] CAS login not merging users with local accounts (#18238)

* Bump version to 3.4.2

* Bump version to 3.5.0-rc.0

* Bump version to 3.5.0-rc.1

* Bump version to 3.5.0-rc.2

* Bump version to 3.5.0-rc.3

* Bump version to 3.5.0-rc.4

* Bump version to 3.5.0

* Bump version to 3.6.0-develop

Co-authored-by: Guilherme Gazzo <[email protected]>
Co-authored-by: Maria Eduarda Cunha <[email protected]>
Co-authored-by: gabriellsh <[email protected]>
Co-authored-by: Renato Becker <[email protected]>
Co-authored-by: Rodrigo Nascimento <[email protected]>
Co-authored-by: Paulo Bernardo <[email protected]>
Co-authored-by: Denis <[email protected]>
Co-authored-by: Omar Chehab <[email protected]>
Co-authored-by: pierre-lehnen-rc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcosSpessatto MarcosSpessatto MarcosSpessatto approved these changes

@rodrigok rodrigok Awaiting requested review from rodrigok

Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
3.4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@renatobecker @MarcosSpessatto