Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Sign in with apple (iOS client only) #18258

Merged
merged 10 commits into from
Jul 14, 2020
Merged

[NEW] Sign in with apple (iOS client only) #18258

merged 10 commits into from
Jul 14, 2020

Conversation

djorkaeffalexandre
Copy link
Contributor

@djorkaeffalexandre djorkaeffalexandre commented Jul 14, 2020

Proposed changes

Add a new login handler to Sign in with Apple service, it'll be showed only on our iOS client.

Issue(s)

How to test or reproduce

  1. Start a server
  2. Enable Apple OAuth
  3. Connect using our iOS App ([NEW] Sign in with Apple Rocket.Chat.ReactNative#2282)
  4. Login using Continue with Apple

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Add Sign in with Apple service for the iOS client-only, support for the Web and Android clients will land in future releases.

Further comments

@rodrigok rodrigok changed the title [NEW] Sign in with apple (iOS Client) [NEW] Sign in with apple (iOS client only) Jul 14, 2020
@rodrigok rodrigok added this to the 3.5.0 milestone Jul 14, 2020
@rodrigok rodrigok merged commit 6429353 into RocketChat:develop Jul 14, 2020
gabriellsh added a commit that referenced this pull request Jul 15, 2020
…ite/accounts

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression: Message actions under "unread messages" warning (#18273)
  [NEW] Added profile field to inform Nickname for users in order to be searchable (#18260)
  [NEW] Sign in with apple (iOS client only) (#18258)
  [IMPROVE] Message action styles (#18190)
  Rewrite Contextual Bar Discussion List in React (#18127)
  Regression: Remove calls to Console API in useForm hook (#18244)
  [FIX]Update link URL at AppsWhatIsIt (#18240)
  Update the API of React Hooks using Meteor's reactive system (#18226)
  [FIX] CAS login not merging users with local accounts (#18238)
  [FIX] SAML login crashing when receiving an array of roles (#18224)
  [FIX] Application not loading due to reverse proxy decoding API calls unnecessarily (#18222)
  Update Apps-Engine version (#18212)
  [FIX] Old Data Migrations breaking upgrades (#18185)
gabriellsh added a commit that referenced this pull request Jul 15, 2020
…into rewrite/user_preferences

* 'rewrite/accounts' of github.com:RocketChat/Rocket.Chat:
  Regression: Message actions under "unread messages" warning (#18273)
  [NEW] Added profile field to inform Nickname for users in order to be searchable (#18260)
  [NEW] Sign in with apple (iOS client only) (#18258)
  [IMPROVE] Message action styles (#18190)
  Rewrite Contextual Bar Discussion List in React (#18127)
  Regression: Remove calls to Console API in useForm hook (#18244)
  [FIX]Update link URL at AppsWhatIsIt (#18240)
  Update the API of React Hooks using Meteor's reactive system (#18226)
  [FIX] CAS login not merging users with local accounts (#18238)
  [FIX] SAML login crashing when receiving an array of roles (#18224)
  [FIX] Application not loading due to reverse proxy decoding API calls unnecessarily (#18222)
  Update Apps-Engine version (#18212)
  [FIX] Old Data Migrations breaking upgrades (#18185)
@sampaiodiego sampaiodiego mentioned this pull request Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants