-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] Sign in with apple (iOS client only) #18258
Merged
rodrigok
merged 10 commits into
RocketChat:develop
from
djorkaeffalexandre:new.sign-in-with-apple
Jul 14, 2020
Merged
[NEW] Sign in with apple (iOS client only) #18258
rodrigok
merged 10 commits into
RocketChat:develop
from
djorkaeffalexandre:new.sign-in-with-apple
Jul 14, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto new.sign-in-with-apple
…alexandre/Rocket.Chat into new.sign-in-with-apple
rodrigok
approved these changes
Jul 14, 2020
gabriellsh
added a commit
that referenced
this pull request
Jul 15, 2020
…ite/accounts * 'develop' of github.com:RocketChat/Rocket.Chat: Regression: Message actions under "unread messages" warning (#18273) [NEW] Added profile field to inform Nickname for users in order to be searchable (#18260) [NEW] Sign in with apple (iOS client only) (#18258) [IMPROVE] Message action styles (#18190) Rewrite Contextual Bar Discussion List in React (#18127) Regression: Remove calls to Console API in useForm hook (#18244) [FIX]Update link URL at AppsWhatIsIt (#18240) Update the API of React Hooks using Meteor's reactive system (#18226) [FIX] CAS login not merging users with local accounts (#18238) [FIX] SAML login crashing when receiving an array of roles (#18224) [FIX] Application not loading due to reverse proxy decoding API calls unnecessarily (#18222) Update Apps-Engine version (#18212) [FIX] Old Data Migrations breaking upgrades (#18185)
gabriellsh
added a commit
that referenced
this pull request
Jul 15, 2020
…into rewrite/user_preferences * 'rewrite/accounts' of github.com:RocketChat/Rocket.Chat: Regression: Message actions under "unread messages" warning (#18273) [NEW] Added profile field to inform Nickname for users in order to be searchable (#18260) [NEW] Sign in with apple (iOS client only) (#18258) [IMPROVE] Message action styles (#18190) Rewrite Contextual Bar Discussion List in React (#18127) Regression: Remove calls to Console API in useForm hook (#18244) [FIX]Update link URL at AppsWhatIsIt (#18240) Update the API of React Hooks using Meteor's reactive system (#18226) [FIX] CAS login not merging users with local accounts (#18238) [FIX] SAML login crashing when receiving an array of roles (#18224) [FIX] Application not loading due to reverse proxy decoding API calls unnecessarily (#18222) Update Apps-Engine version (#18212) [FIX] Old Data Migrations breaking upgrades (#18185)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add a new login handler to Sign in with Apple service, it'll be showed only on our iOS client.
Issue(s)
How to test or reproduce
Continue with Apple
Screenshots
Types of changes
Checklist
Changelog
Add Sign in with Apple service for the iOS client-only, support for the Web and Android clients will land in future releases.
Further comments