Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] External MP3 encoder worker for audio recording #18277

Merged
merged 2 commits into from
Jul 17, 2020
Merged

Conversation

tassoevan
Copy link
Contributor

Proposed changes

Uses @rocket.chat/mp3-encoder as the worker for audio record encoding. It permits a better control about the worker's source, including third-party dependency management and bundling.

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@tassoevan tassoevan added this to the 3.5.0 milestone Jul 15, 2020
@tassoevan tassoevan requested a review from a team July 15, 2020 21:44
@ggazzo ggazzo merged commit 20483a8 into develop Jul 17, 2020
@ggazzo ggazzo deleted the feat/mp3-encoder branch July 17, 2020 01:27
@sampaiodiego sampaiodiego mentioned this pull request Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants