Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Update check not able to be disabled #18339

Merged
merged 3 commits into from
Jul 22, 2020

Conversation

graywolf336
Copy link
Contributor

@graywolf336 graywolf336 commented Jul 21, 2020

Proposed changes

Way back in v0.62.0 an update check was implemented into Rocket.Chat (b81b366). The concept behind this update checker was to notify Rocket.Chat server administrators about new releases and security releases. Neither the server side update notification nor the alert server were ever implemented up until the end of May 2020. Up until now, there was no way, inside Rocket.Chat, to disable this update/alert checker. Moving forward, this will require that people select Register Server in the setup wizard in order for this update check to be enabled. Disabling it is as simple as going into Rocket.Chat's settings and disabling the registration of the server in the Wizard settings. Thus, this requires that an administrator of the server intentionally enable this and we will not have it enabled by default anymore nor will we make the decision of whether to enable or disable it: the choice is in the hands of the server administrator.

Here is the data sent:

const params = {
uniqueId: uniqueID.value,
installedAt: uniqueID.createdAt.toJSON(),
version: Info.version,
osType: os.type(),
osPlatform: os.platform(),
osArch: os.arch(),
osRelease: os.release(),
nodeVersion: process.version,
deployMethod: process.env.DEPLOY_METHOD || 'tar',
deployPlatform: process.env.DEPLOY_PLATFORM || 'selfinstall',
};

Items Left To Do:

  • New setting underneath the General -> Update
  • Add it in additional to the check for the intent to register your server

Issue(s)

Closes #18331

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes

Changelog

Doing it this way enables people to easily disable the update
check just like they can sending data to Rocket.Chat services.
@geekgonecrazy geekgonecrazy marked this pull request as ready for review July 22, 2020 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Policy violation - server pulling update messages from Rocket.Chat cloud without permission
3 participants