[FIX] Update check not able to be disabled #18339
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Way back in v0.62.0 an update check was implemented into Rocket.Chat (b81b366). The concept behind this update checker was to notify Rocket.Chat server administrators about new releases and security releases. Neither the server side update notification nor the alert server were ever implemented up until the end of May 2020. Up until now, there was no way, inside Rocket.Chat, to disable this update/alert checker. Moving forward, this will require that people select
Register Server
in the setup wizard in order for this update check to be enabled. Disabling it is as simple as going into Rocket.Chat's settings and disabling the registration of the server in the Wizard settings. Thus, this requires that an administrator of the server intentionally enable this and we will not have it enabled by default anymore nor will we make the decision of whether to enable or disable it: the choice is in the hands of the server administrator.Here is the data sent:
Rocket.Chat/app/version-check/server/functions/getNewUpdates.js
Lines 14 to 25 in ba74996
Items Left To Do:
General -> Update
Issue(s)
Closes #18331
Types of changes
Checklist
Changelog