Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Thread reply disappearing and threads result on search #18349

Merged
merged 2 commits into from
Jul 28, 2020
Merged

[FIX] Thread reply disappearing and threads result on search #18349

merged 2 commits into from
Jul 28, 2020

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Jul 22, 2020 •
edited by dougfabris
Loading

closes #18340
closes #18337
closes #20153

Proposed changes

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@ggazzo ggazzo added this to the 3.5.0 milestone Jul 22, 2020
@ggazzo ggazzo changed the title [FIX] Thread reply disappearing [FIX] Thread reply disappearing, Threads on search Jul 22, 2020
@ggazzo ggazzo changed the title [FIX] Thread reply disappearing, Threads on search [FIX] Thread reply disappearing and threads result on search Jul 22, 2020
@ggazzo ggazzo force-pushed the fix/thread-disappearing branch from f425d41 to f99763a Compare July 22, 2020 15:04
@ggazzo ggazzo merged commit 601c7af into develop Jul 28, 2020
@ggazzo ggazzo modified the milestones: 3.5.0, 3.6.0 Jul 28, 2020
@ggazzo ggazzo deleted the fix/thread-disappearing branch July 28, 2020 16:10
@sampaiodiego sampaiodiego mentioned this pull request Aug 29, 2020
Merged
@notatallshaw notatallshaw mentioned this pull request Jan 18, 2021
Closed
@dougfabris dougfabris linked an issue Jan 20, 2021 that may be closed by this pull request
[BUG] Broken empty search results #20153
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabriellsh gabriellsh gabriellsh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.6.0
2 participants
@ggazzo @gabriellsh