Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE] New component and better look for tooltips #18399

Merged
merged 7 commits into from
Jul 28, 2020
Merged

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Jul 28, 2020

Proposed changes

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@ggazzo ggazzo merged commit 0afa7f4 into develop Jul 28, 2020
@ggazzo ggazzo deleted the feat/tooltip branch July 28, 2020 16:07
@rodrigok rodrigok changed the title [NEW] Tooltips [Improve] New component and better looking for tooltips Aug 24, 2020
@rodrigok rodrigok changed the title [Improve] New component and better looking for tooltips [IMPROVE] New component and better looking for tooltips Aug 24, 2020
@rodrigok rodrigok changed the title [IMPROVE] New component and better looking for tooltips [IMPROVE] New component and better look for tooltips Aug 24, 2020
@sampaiodiego sampaiodiego mentioned this pull request Aug 29, 2020
@TBG-FR
Copy link
Contributor

TBG-FR commented Oct 27, 2020

@ggazzo Do you know which tooltip element/component is used when we hover on a mention/@username tag ? Shouldn't it use the component you created ? (I was wandering in the code to find that because I need to customize them for a dark theme, and found out they weren't the same...)

"Emoji" tooltip
image

"Mention" tooltip
image

Same screenshots, after adding a background-color on .tooltip show
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants