Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: Agents Page issues #18684

Merged
merged 3 commits into from
Aug 28, 2020
Merged

Regression: Agents Page issues #18684

merged 3 commits into from
Aug 28, 2020

Conversation

MartinSchoeler
Copy link
Contributor

@MartinSchoeler MartinSchoeler commented Aug 26, 2020 •
edited
Loading

Proposed changes

This PR add:

  • Fix when agent is deleted and a blank screen is presentred
  • Add Modal confirming the deletion of the agents

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@lgtm-com
Copy link

lgtm-com bot commented Aug 26, 2020

This pull request introduces 1 alert when merging 88cdeef into 00c243e - view on LGTM.com

new alerts:

  • 1 for Useless conditional

@tassoevan tassoevan requested a review from a team August 28, 2020 03:03
@tassoevan tassoevan changed the title [REGRESSION] Agents Page regressions Regression: Agents Page issues Aug 28, 2020
@lgtm-com
Copy link

lgtm-com bot commented Aug 28, 2020

This pull request introduces 1 alert when merging 908af7e into b5d199e - view on LGTM.com

new alerts:

  • 1 for Useless conditional

@ggazzo ggazzo force-pushed the omni-regressions/agent branch from 24c7a32 to 0b30f7d Compare August 28, 2020 13:37
@ggazzo ggazzo added this to the 3.6.0 milestone Aug 28, 2020
@ggazzo ggazzo merged commit b590375 into develop Aug 28, 2020
@ggazzo ggazzo deleted the omni-regressions/agent branch August 28, 2020 20:50
@sampaiodiego sampaiodiego mentioned this pull request Aug 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@MartinSchoeler @ggazzo @tassoevan