Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE] Registration Experience #27820

Merged
merged 45 commits into from
Feb 10, 2023
Merged

Conversation

csuadev
Copy link
Contributor

@csuadev csuadev commented Jan 24, 2023

Proposed changes (including videos or screenshots)

If you didn't register when you initially setup your server. Its now easier to register.

Disconnecting and reconnecting your workspace from the cloud is now also easier

Issue(s)

Steps to test or reproduce

Further comments

@PedroRorato PedroRorato changed the title [FEAT] Connectivity services - cloud services squad [IMPROVE] Connectivity services - cloud services squad Jan 30, 2023
@geekgonecrazy geekgonecrazy changed the title [IMPROVE] Connectivity services - cloud services squad [IMPROVE] Connectivity services Feb 3, 2023
@geekgonecrazy geekgonecrazy changed the title [IMPROVE] Connectivity services [IMPROVE] Connectivity services Registration Experience Feb 3, 2023
@geekgonecrazy geekgonecrazy changed the title [IMPROVE] Connectivity services Registration Experience [IMPROVE] Registration Experience Feb 3, 2023
* add: use workspace token when interacting with Marketplace

* fix: formatting

---------

Co-authored-by: Thassio Victor <[email protected]>
Co-authored-by: Aaron Ogle <[email protected]>
* feat: remove login button

* feat: remove login button

* fix: add developmentModeButton

---------

Co-authored-by: Aaron Ogle <[email protected]>
@geekgonecrazy geekgonecrazy force-pushed the feat/CS-19-connectivity-services branch from 7b2ece3 to eb2f9c4 Compare February 9, 2023 19:52
@csuadev csuadev requested a review from a team as a code owner February 9, 2023 21:04
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #27820 (7294865) into develop (0d9b086) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 7294865 differs from pull request most recent head 633c4db. Consider uploading reports for the commit 633c4db to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27820      +/-   ##
===========================================
+ Coverage    41.62%   41.65%   +0.02%     
===========================================
  Files          834      834              
  Lines        17285    17271      -14     
  Branches      2068     2068              
===========================================
- Hits          7195     7194       -1     
+ Misses        9818     9805      -13     
  Partials       272      272              
Flag Coverage Δ
e2e 41.65% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@geekgonecrazy geekgonecrazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! This PR looks pretty clean

@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 10, 2023
@geekgonecrazy geekgonecrazy merged commit 9a70d0c into develop Feb 10, 2023
@geekgonecrazy geekgonecrazy deleted the feat/CS-19-connectivity-services branch February 10, 2023 23:42
@janainaCoelhoRocketchat janainaCoelhoRocketchat added this to the 6.0.0 milestone Feb 13, 2023
gabriellsh added a commit that referenced this pull request Feb 13, 2023
…e/wizard

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [BREAK] Unify monolith and microservices intercommunication on same technology and limit to Enterprise only (#27969)
  [NEW] Emojis rendering properly on quote message previews (#27972)
  Chore: Wait message to not be Busy (#28000)
  Chore: e2e changes tests (#27987)
  [IMPROVE] Audit (#27994)
  [IMPROVE] Registration Experience (#27820)
  [BREAK][ENTERPRISE] Limit presence statuses to 200 concurrent users when running monolith to keep performance (#27854)
  [BREAK] Removed deprecated settings for Legacy Messages, Marked, Snippet Messages, Autolinker and IssueLinks (#27902)
  [NEW] Permission to bypass message editing and removing limits (#27644)
  [FIX] Video Conf Message Blocks not always updating when running on micro services (#27764)
  Chore: Set missing colors (#27817)
  Fix CI
  Chore: undo busy selector
  [BREAK] Remove message view mode from User Preferences (#27867)
  Chore: Aria busy indicators (#27978)
  Chore: Refactor Composer Dropdown (#27931)
  Chore: Added Enterprise Options to Login customization (#27855)
  [FIX] Ignored messages reactivity (#27279)
  [BREAK] [NEW] Custom roles upsell modal (#27707)
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad: cloud stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants