Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: "Discussions" filter is prioritized in admin "Rooms" page #28426

Merged
merged 33 commits into from
Jun 13, 2023

Conversation

heitortanoue
Copy link
Contributor

@heitortanoue heitortanoue commented Mar 15, 2023

Description:

Discussion filter is being prioritized on the filter - even if the user selects more the one it will only return discussion if the checkbox is selected

Preconditions:

Have created dm’s, channels, and teams before starting the testing

Steps to reproduce:

  • Go to Admin -> Rooms
  • Select all the checkboxes

Expected Behavior:

It should filter by all of the filters selected

Actual Behavior:

If the user selects discussion, it only filters by discussion - ignoring all the other checkboxes

TC-526

@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #28426 (8791f5f) into develop (ea0bbba) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28426      +/-   ##
===========================================
- Coverage    46.68%   46.63%   -0.06%     
===========================================
  Files          699      699              
  Lines        13081    13081              
  Branches      2228     2228              
===========================================
- Hits          6107     6100       -7     
- Misses        6652     6657       +5     
- Partials       322      324       +2     
Flag Coverage Δ
e2e 46.60% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@heitortanoue heitortanoue requested a review from a team as a code owner March 17, 2023 17:55
@heitortanoue heitortanoue requested a review from a team as a code owner March 23, 2023 10:16
@matheusbsilva137 matheusbsilva137 requested a review from a team as a code owner March 29, 2023 18:09
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 9, 2023
@scuciatto scuciatto added this to the 6.3.0 milestone May 15, 2023
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label May 22, 2023
@changeset-bot
Copy link

changeset-bot bot commented May 22, 2023

🦋 Changeset detected

Latest commit: 8791f5f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/model-typings Patch
@rocket.chat/models Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/omnichannel-services Patch
rocketchat-services Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/instance-status Patch
@rocket.chat/presence Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/api-client Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/uikit-playground Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 22, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels May 22, 2023
@matheusbsilva137 matheusbsilva137 changed the title fix: admin rooms page filters fix: "Discussions" filter is prioritized in admin "Rooms" page May 22, 2023
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label May 22, 2023
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 22, 2023
@matheusbsilva137 matheusbsilva137 requested a review from a team as a code owner June 9, 2023 13:03
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jun 9, 2023
@ggazzo ggazzo merged commit 16dca46 into develop Jun 13, 2023
@ggazzo ggazzo deleted the fix/admin-rooms-checkboxes branch June 13, 2023 19:12
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants