-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: "Discussions" filter is prioritized in admin "Rooms" page #28426
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #28426 +/- ##
===========================================
- Coverage 46.68% 46.63% -0.06%
===========================================
Files 699 699
Lines 13081 13081
Branches 2228 2228
===========================================
- Hits 6107 6100 -7
- Misses 6652 6657 +5
- Partials 322 324 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
…nto fix/admin-rooms-checkboxes
🦋 Changeset detectedLatest commit: 8791f5f The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Description:
Discussion filter is being prioritized on the filter - even if the user selects more the one it will only return discussion if the checkbox is selected
Preconditions:
Have created dm’s, channels, and teams before starting the testing
Steps to reproduce:
Expected Behavior:
It should filter by all of the filters selected
Actual Behavior:
If the user selects discussion, it only filters by discussion - ignoring all the other checkboxes
TC-526