Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Misaligned alignment of prompt when hover on user / room name in room information and user information section #28627

Merged
merged 4 commits into from
Jun 29, 2023

Conversation

Bankar-Swapnil
Copy link
Contributor

For solving this issue,
changes are done in apps/meteor/client/components/InfoPanel/InfoPanelTitle.tsx file and checked it on my local environment and it works fine. Please review this.

Proposed changes (including videos or screenshots)

new1.mp4

Issue(s)

closes #28626

Steps to test or reproduce

  1. click on user information / click on room information
  2. hover on user name / hover on room name

@Bankar-Swapnil Bankar-Swapnil requested a review from a team as a code owner March 26, 2023 07:55
@Bankar-Swapnil Bankar-Swapnil changed the title [FIX]Misaligned alignment of prompt when hover on user / room name in room information and user information section #28626 fix: Misaligned alignment of prompt when hover on user / room name in room information and user information section #28626 Mar 26, 2023
@codecov
Copy link

codecov bot commented Mar 26, 2023

Codecov Report

Merging #28627 (08c336a) into develop (955fbbc) will decrease coverage by 0.74%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28627      +/-   ##
===========================================
- Coverage    46.41%   45.67%   -0.74%     
===========================================
  Files          700      694       -6     
  Lines        13043    12982      -61     
  Branches      2235     2222      -13     
===========================================
- Hits          6054     5930     -124     
- Misses        6662     6727      +65     
+ Partials       327      325       -2     
Flag Coverage Δ
e2e 45.65% <ø> (-0.74%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@hugocostadev
Copy link
Contributor

Hi there, thanks for your contribution! 🚀 💯

@dougfabris dougfabris changed the title fix: Misaligned alignment of prompt when hover on user / room name in room information and user information section #28626 fix: Misaligned alignment of prompt when hover on user / room name in room information and user information section Mar 29, 2023
@hugocostadev hugocostadev added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Apr 6, 2023
@hugocostadev hugocostadev added this to the 6.3.0 milestone Apr 23, 2023
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Apr 23, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jun 20, 2023

⚠️ No Changeset found

Latest commit: 08c336a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ggazzo ggazzo merged commit 5688ff6 into RocketChat:develop Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misaligned alignment of prompt when hover on user / room name in room information and user information section
3 participants