Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Broken link fixed inside webhook menu #29048

Merged
merged 7 commits into from
May 31, 2023

Conversation

anikdhabal
Copy link
Contributor

Proposed changes (including videos or screenshots)

Broken link fixed Inside webhooks of omnichannel menu.
Before:-

Untitled.design.17.mp4

After:-

Untitled.design.19.mp4

Issue(s)

fix #29042

Steps to test or reproduce

  1. Go to Administration
  2. Click on omnichannel
  3. Open webhook

Further comments

@anikdhabal anikdhabal requested a review from a team as a code owner April 25, 2023 16:35
@hugocostadev hugocostadev added this to the 6.3.0 milestone Apr 26, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Apr 26, 2023
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #29048 (bc6a7c1) into develop (d33f4eb) will decrease coverage by 0.08%.
The diff coverage is n/a.

❗ Current head bc6a7c1 differs from pull request most recent head 78493e1. Consider uploading reports for the commit 78493e1 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #29048      +/-   ##
===========================================
- Coverage    46.73%   46.65%   -0.08%     
===========================================
  Files          698      698              
  Lines        13075    13071       -4     
  Branches      2227     2226       -1     
===========================================
- Hits          6110     6098      -12     
- Misses        6649     6653       +4     
- Partials       316      320       +4     
Flag Coverage Δ
e2e 46.61% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels May 1, 2023
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label May 29, 2023
@changeset-bot
Copy link

changeset-bot bot commented May 29, 2023

⚠️ No Changeset found

Latest commit: 78493e1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hugocostadev hugocostadev added the stat: ready to merge PR tested and approved waiting for merge label May 31, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels May 31, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels May 31, 2023
@kodiakhq kodiakhq bot merged commit 9959bc6 into RocketChat:develop May 31, 2023
gabriellsh added a commit that referenced this pull request Jun 1, 2023
…e/system-messages-update

* 'develop' of github.com:RocketChat/Rocket.Chat: (26 commits)
  fix: Importer crashes when sending the "active status" e-mail notification to users (#29401)
  docs: new README file (#27955)
  refactor: replace with new `Select` (#29368)
  fix: Sidebar's sort by name not being checked properly (#29415)
  fix: Login Terms custom content (#28999)
  fix: Broken link fixed inside webhook menu (#29048)
  fix: Apps settings i18n translation (#29394)
  fix: OTR session closing after 10 seconds without warning (#29245)
  fix: Register Username form showing before homepage (#29356)
  regression(ui-client): Toolbox action button badge in the wrong position (#29412)
  fix: marketplace filters are changing size (#28738)
  chore: Update highlighted word color (#29407)
  i18n: Language update from LingoHub 🤖 on 2023-05-22Z (#29317)
  chore(ddp-sdk): ts-jest -> swc/jest (#29380)
  chore: `ToolboxAction` pressed state (#29397)
  chore: add logs to recurring omnichannel cron jobs (#29392)
  regression: `t` using always sprintf (#29396)
  fix: fix wrong %s translations (#29395)
  regression(push): fix error when selecting what to import (#29289)
  chore: Change ddpsdk.stream to return subscription (#29375)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
communityPR stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link is Broken inside omnichannel
3 participants