-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement new password verification flow front #29322
Conversation
|
Codecov Report
@@ Coverage Diff @@
## develop #29322 +/- ##
===========================================
- Coverage 46.56% 46.50% -0.06%
===========================================
Files 695 695
Lines 12987 12987
Branches 2236 2236
===========================================
- Hits 6047 6040 -7
- Misses 6615 6621 +6
- Partials 325 326 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
Implemented the visual part of the password verification system. Will be connecting it to the logic next.
Finished implementing the password verification flow in the web-ui-registration package. Next will implement the flow in the other password fields accross RC. Also changed the pw.getPolicy endpoint to not need login permission and added the new translation entries to the i18n dictionary.
Implemented the PasswordVerifier component on the profile and reset password pages. Waiting for confirmation on how to better handle the usePasswordPolicy hook.
Added some necessary verifications to the places in which the PasswordVerifier is being used, created/modified some translation entries and added a password confirmation field to the reset password page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial code review, I still need to check other things
apps/meteor/client/views/account/profile/AccountProfileForm.tsx
Outdated
Show resolved
Hide resolved
packages/web-ui-registration/src/ResetPassword/ResetPasswordPage.tsx
Outdated
Show resolved
Hide resolved
…cket.Chat into feat/password-verification
Proposed changes (including videos or screenshots)
Jira task: SUP-45
Created a hook and a component to verify passwords written in the register user, My Profile and reset password pages. Also opened the pw.getPolicy endpoint to non-logged in users and changed the usePasswordPolicy hook from the web-ui-registration package to ui-contexts.
Demo gif:
Issue(s)
Steps to test or reproduce
Further comments