Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement new password verification flow front #29322

Merged
merged 31 commits into from
Jun 22, 2023

Conversation

rique223
Copy link
Contributor

@rique223 rique223 commented May 22, 2023

Proposed changes (including videos or screenshots)

Jira task: SUP-45

Created a hook and a component to verify passwords written in the register user, My Profile and reset password pages. Also opened the pw.getPolicy endpoint to non-logged in users and changed the usePasswordPolicy hook from the web-ui-registration package to ui-contexts.
Demo gif:
password_verification

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented May 22, 2023

⚠️ No Changeset found

Latest commit: 3508879

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #29322 (3508879) into develop (5653f10) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #29322      +/-   ##
===========================================
- Coverage    46.56%   46.50%   -0.06%     
===========================================
  Files          695      695              
  Lines        12987    12987              
  Branches      2236     2236              
===========================================
- Hits          6047     6040       -7     
- Misses        6615     6621       +6     
- Partials       325      326       +1     
Flag Coverage Δ
e2e 46.47% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

rique223 added 7 commits May 23, 2023 17:39
Implemented the visual part of the password verification system. Will be connecting it to the logic next.
Finished implementing the password verification flow in the web-ui-registration package. Next will implement the flow in the other password fields accross RC. Also changed the pw.getPolicy endpoint to not need login permission and added the new translation entries to the i18n dictionary.
Implemented the PasswordVerifier component on the profile and reset password pages. Waiting for confirmation on how to better handle the usePasswordPolicy hook.
Added some necessary verifications to the places in which the PasswordVerifier is being used, created/modified some translation entries and added a password confirmation field to the reset password page.
@rique223 rique223 changed the title feat: Implement new password verification flow feat: Implement new password verification flow front May 31, 2023
@rique223 rique223 marked this pull request as ready for review June 1, 2023 16:27
@rique223 rique223 requested review from a team as code owners June 1, 2023 16:27
Copy link
Contributor

@hugocostadev hugocostadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial code review, I still need to check other things

packages/rest-typings/src/v1/misc.ts Outdated Show resolved Hide resolved
apps/meteor/app/api/server/v1/misc.ts Outdated Show resolved Hide resolved
password-verification-front.md Outdated Show resolved Hide resolved
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Jun 14, 2023
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 15, 2023
hugocostadev
hugocostadev previously approved these changes Jun 16, 2023
tapiarafael
tapiarafael previously approved these changes Jun 16, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jun 16, 2023
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Jun 16, 2023
@hugocostadev hugocostadev dismissed stale reviews from tapiarafael and themself via 90c2de6 June 16, 2023 19:21
@casalsgh casalsgh requested a review from a team June 19, 2023 14:30
@rique223 rique223 requested a review from tapiarafael June 19, 2023 18:22
@ggazzo ggazzo merged commit b2168e8 into develop Jun 22, 2023
@ggazzo ggazzo deleted the feat/password-verification branch June 22, 2023 23:44
AdityaSingh-02 pushed a commit to AdityaSingh-02/Rocket.Chat that referenced this pull request Jun 24, 2023
@hugocostadev hugocostadev added the squad: Workspace Management squad: Workspace Management label Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad: Workspace Management squad: Workspace Management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants