Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: Fix secondary presence streamer #29340

Merged
merged 2 commits into from
May 24, 2023
Merged

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented May 23, 2023

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented May 23, 2023

⚠️ No Changeset found

Latest commit: ed2b402

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ggazzo ggazzo marked this pull request as ready for review May 23, 2023 16:36
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #29340 (ed2b402) into develop (0907513) will increase coverage by 0.05%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #29340      +/-   ##
===========================================
+ Coverage    46.78%   46.84%   +0.05%     
===========================================
  Files          707      707              
  Lines        13238    13239       +1     
  Branches      2220     2221       +1     
===========================================
+ Hits          6194     6202       +8     
+ Misses        6729     6724       -5     
+ Partials       315      313       -2     
Flag Coverage Δ
e2e 46.80% <75.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels May 24, 2023
@kodiakhq kodiakhq bot merged commit 89e2c26 into develop May 24, 2023
@kodiakhq kodiakhq bot deleted the regression/sdk-presence-2 branch May 24, 2023 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants