-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Omnichannel making an excessive amount of requests to room.info #29425
Conversation
🦋 Changeset detectedLatest commit: db584b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #29425 +/- ##
============================================
+ Coverage 36.32% 46.47% +10.15%
============================================
Files 626 698 +72
Lines 12149 13019 +870
Branches 2147 2235 +88
============================================
+ Hits 4413 6051 +1638
+ Misses 7457 6643 -814
- Partials 279 325 +46
Flags with carried forward coverage won't be shown. Click here to find out more. |
@aleksandernsilva , is there a way to test this? |
@KevLehman updated task description with more informations about the issue 😉 |
Proposed changes (including videos or screenshots)
Issue(s)
OC-1029
Steps to test or reproduce
These are the two scenarios I believe needs to be tested and working to consider this fix effective.
Basically any editing done to a room (priority change, sla change, forwarding) while the room info contextual bar is open will trigger multiple requests to the
room.info
endpoints.Further comments
These are the two scenarios I believe needs to be tested and working to consider this fix effective.
This is simple, as initially reported interacting with a room should not cause multiple
room.info
requests (editing, forwarding, etc)Any room information changed by an agent should be updated in real time for all other agents.