Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Omnichannel making an excessive amount of requests to room.info #29425

Merged
merged 9 commits into from
Jun 21, 2023

Conversation

aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Jun 1, 2023

Proposed changes (including videos or screenshots)

Issue(s)

OC-1029

Steps to test or reproduce

These are the two scenarios I believe needs to be tested and working to consider this fix effective.

Basically any editing done to a room (priority change, sla change, forwarding) while the room info contextual bar is open will trigger multiple requests to the room.info endpoints.

Further comments

These are the two scenarios I believe needs to be tested and working to consider this fix effective.

  1. This is simple, as initially reported interacting with a room should not cause multiple room.info requests (editing, forwarding, etc)

  2. Any room information changed by an agent should be updated in real time for all other agents.

@changeset-bot
Copy link

changeset-bot bot commented Jun 1, 2023

🦋 Changeset detected

Latest commit: db584b9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/api-client Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #29425 (db584b9) into develop (0e1a4d0) will increase coverage by 10.15%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop   #29425       +/-   ##
============================================
+ Coverage    36.32%   46.47%   +10.15%     
============================================
  Files          626      698       +72     
  Lines        12149    13019      +870     
  Branches      2147     2235       +88     
============================================
+ Hits          4413     6051     +1638     
+ Misses        7457     6643      -814     
- Partials       279      325       +46     
Flag Coverage Δ
e2e 46.43% <0.00%> (+10.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@aleksandernsilva aleksandernsilva marked this pull request as ready for review June 2, 2023 13:07
@aleksandernsilva aleksandernsilva requested review from a team as code owners June 2, 2023 13:07
@aleksandernsilva aleksandernsilva added this to the 6.3.0 milestone Jun 2, 2023
@KevLehman
Copy link
Contributor

@aleksandernsilva , is there a way to test this?

@aleksandernsilva
Copy link
Contributor Author

@KevLehman updated task description with more informations about the issue 😉

MartinSchoeler
MartinSchoeler previously approved these changes Jun 6, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jun 20, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jun 20, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jun 21, 2023
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Jun 21, 2023
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 21, 2023
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Jun 21, 2023
@aleksandernsilva aleksandernsilva added the stat: ready to merge PR tested and approved waiting for merge label Jun 21, 2023
@kodiakhq kodiakhq bot merged commit a7098c8 into develop Jun 21, 2023
@kodiakhq kodiakhq bot deleted the fix/room-info-excessive-requests branch June 21, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad: omnichannel stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants