Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression(i18n): Broken translations on client-side startup #29442

Merged
merged 6 commits into from
Jun 9, 2023

Conversation

tassoevan
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Jun 3, 2023

⚠️ No Changeset found

Latest commit: 98279b1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Jun 3, 2023

Codecov Report

Merging #29442 (98279b1) into develop (5408835) will increase coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #29442   +/-   ##
========================================
  Coverage    46.67%   46.67%           
========================================
  Files          699      699           
  Lines        13081    13087    +6     
  Branches      2228     2228           
========================================
+ Hits          6106     6109    +3     
+ Misses        6656     6655    -1     
- Partials       319      323    +4     
Flag Coverage Δ
e2e 46.64% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan force-pushed the fix/i18n-initialization branch 5 times, most recently from 4f25ca7 to a48d040 Compare June 6, 2023 21:45
@tassoevan tassoevan force-pushed the fix/i18n-initialization branch from a48d040 to b7ec481 Compare June 6, 2023 22:33
@tassoevan tassoevan marked this pull request as ready for review June 7, 2023 02:37
@tassoevan tassoevan requested a review from a team as a code owner June 7, 2023 02:37
@ggazzo ggazzo changed the title fix(i18n): Broken translations on client-side startup regression(i18n): Broken translations on client-side startup Jun 7, 2023
ggazzo
ggazzo previously approved these changes Jun 7, 2023
@ggazzo ggazzo merged commit b979530 into develop Jun 9, 2023
@ggazzo ggazzo deleted the fix/i18n-initialization branch June 9, 2023 15:55
gabriellsh added a commit that referenced this pull request Jun 12, 2023
…memberList

* 'develop' of github.com:RocketChat/Rocket.Chat: (43 commits)
  chore: Pages empty state consistency (#29439)
  refactor: Convert Omnichannel helper ee to ts (#29274)
  regression(i18n): Broken translations on client-side startup (#29442)
  chore: break down helpers.ts and create new files (#28611)
  test: runInBand unit test (#29484)
  i18n: system message copy updates (#29372)
  chore: emoji popup trigger length (#29282)
  fix: Seat counter including apps (#29489)
  fix: Invalid message draft (#29474)
  fix: message deletion fails if has files attached on filesystem storage (#29313)
  chore: replace meteor.call -> sdk.call (#29318)
  chore: deprecation api (#29347)
  fix: Imported messages are not displayed (#29416)
  chore: convert metrics to ts (#29475)
  chore: use new Livechat SDK Implementation (#29098)
  fix: Room history scroll position (#29335)
  fix: check for $addToSet to be not empty before passing update params (#29378)
  chore: update `badge-level-0` color (#29460)
  fix: Saving Business hour throws an alert (#29449)
  regression: emojiPicker position (#29408)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants