Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Toolbox Options visual consistency #29482

Merged
merged 4 commits into from
Jun 13, 2023
Merged

Conversation

juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Jun 6, 2023

DSAR-172

Proposed changes (including videos or screenshots)

  • add gap on Options without Icon

before:
image

now:
image

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Jun 6, 2023

⚠️ No Changeset found

Latest commit: bc169a7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #29482 (bc169a7) into develop (90d310a) will decrease coverage by 0.20%.
The diff coverage is 51.63%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #29482      +/-   ##
===========================================
- Coverage    46.88%   46.69%   -0.20%     
===========================================
  Files          729      699      -30     
  Lines        13880    13087     -793     
  Branches      2197     2228      +31     
===========================================
- Hits          6508     6111     -397     
+ Misses        7054     6655     -399     
- Partials       318      321       +3     
Flag Coverage Δ
e2e 46.67% <51.63%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@juliajforesti juliajforesti marked this pull request as ready for review June 7, 2023 14:29
@juliajforesti juliajforesti requested a review from a team as a code owner June 7, 2023 14:29
@ggazzo ggazzo merged commit 11eb9de into develop Jun 13, 2023
@ggazzo ggazzo deleted the chore/toolbox-app-option branch June 13, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants