Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use FlowRoute through a facade #29507

Merged
merged 35 commits into from
Jul 5, 2023
Merged

chore: Use FlowRoute through a facade #29507

merged 35 commits into from
Jul 5, 2023

Conversation

tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Jun 9, 2023

Proposed changes (including videos or screenshots)

Issue(s)

ARCH-1127

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Jun 9, 2023

⚠️ No Changeset found

Latest commit: 96db98b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #29507 (96db98b) into develop (c7ff055) will decrease coverage by 0.07%.
The diff coverage is 48.82%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #29507      +/-   ##
===========================================
- Coverage    46.59%   46.52%   -0.07%     
===========================================
  Files          693      691       -2     
  Lines        12946    12948       +2     
  Branches      2242     2243       +1     
===========================================
- Hits          6032     6024       -8     
- Misses        6588     6599      +11     
+ Partials       326      325       -1     
Flag Coverage Δ
e2e 46.49% <48.82%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan force-pushed the refactor/routing branch 6 times, most recently from 6e142aa to a8305ec Compare June 16, 2023 05:10
@tassoevan tassoevan force-pushed the refactor/routing branch 2 times, most recently from a2321ab to aae541f Compare June 19, 2023 17:49
@tassoevan tassoevan force-pushed the refactor/routing branch 17 times, most recently from c412fca to 27039b1 Compare July 4, 2023 02:08
@tassoevan tassoevan marked this pull request as ready for review July 4, 2023 20:40
@tassoevan tassoevan requested review from a team as code owners July 4, 2023 20:40
@tassoevan tassoevan changed the title chore: refactor/routing chore: Use FlowRoute through a facade Jul 4, 2023
ggazzo
ggazzo previously approved these changes Jul 4, 2023
Copy link
Contributor

@MartinSchoeler MartinSchoeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I take a livechat and then move it back to queue, the router tries to go /home but the screen is stuck in this state
Screen Shot 2023-07-05 at 10 17 28

@MartinSchoeler
Copy link
Contributor

There are also cases that the url changes but the page does not
Screen Shot 2023-07-05 at 10 19 54

@MartinSchoeler MartinSchoeler dismissed their stale review July 5, 2023 17:21

Apparently something is going on with my local, and these issues are not happening in other instances

@ggazzo ggazzo merged commit 4da8801 into develop Jul 5, 2023
@ggazzo ggazzo deleted the refactor/routing branch July 5, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants