fix: Direct message notification #29578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b883e44 The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ggazzo
force-pushed
the
fix/multi-dm-notification
branch
from
4c1f1a5 to
0c5bf7d
Compare
Codecov Report
@@ Coverage Diff @@
## develop #29578 +/- ##
===========================================
+ Coverage 39.46% 46.38% +6.92%
===========================================
Files 671 700 +29
Lines 12703 13043 +340
Branches 2174 2235 +61
===========================================
+ Hits 5013 6050 +1037
+ Misses 7394 6665 -729
- Partials 296 328 +32
Flags with carried forward coverage won't be shown. Click here to find out more. |
KevLehman
approved these changes
Jun 19, 2023
| @@ -110,4 +109,4 @@ roomCoordinator.add(DirectMessageRoomType, { | |||
| includeInDashboard() { | |||
| return true; | |||
| }, | |||
| } as AtLeast<IRoomTypeServerDirectives, 'isGroupChat' | 'roomName'>); | |||
| } satisfies AtLeast<IRoomTypeServerDirectives, 'isGroupChat' | 'roomName'>); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments