fix: Dont update a user's livechat status when its status is offline #29589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 95c82aa The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #29589 +/- ##
===========================================
+ Coverage 45.64% 46.59% +0.94%
===========================================
Files 685 692 +7
Lines 12931 12921 -10
Branches 2217 2234 +17
===========================================
+ Hits 5902 6020 +118
+ Misses 6712 6575 -137
- Partials 317 326 +9
Flags with carried forward coverage won't be shown. Click here to find out more. |
KevLehman
commented
Jun 20, 2023
…etChat/Rocket.Chat into fix/bh-manual-offline-not-available
murtaza98
reviewed
Jun 22, 2023
murtaza98
previously approved these changes
Jun 22, 2023
|
@KevLehman Can you think of any API tests we can add here to verify this fix? |
Co-authored-by: Murtaza Patrawala <[email protected]>
murtaza98
previously approved these changes
Jun 22, 2023
ggazzo
previously requested changes
Jun 23, 2023
dionisio-bot
bot
added
stat: ready to merge
murtaza98
previously approved these changes
Jun 23, 2023
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
murtaza98
approved these changes
Jun 26, 2023
ggazzo
approved these changes
Jun 29, 2023
dionisio-bot
bot
removed
the
stat: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OC-1069
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments