Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove old deprecated GenericTable in favor of v2 #29594

Merged
merged 18 commits into from
Jun 22, 2023

Conversation

dougfabris
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Jun 20, 2023

⚠️ No Changeset found

Latest commit: 4c951b9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dougfabris dougfabris changed the title chore: Remove deprecated GenericTable chore: Remove old deprecated GenericTable in favor of v2 Jun 21, 2023
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #29594 (4c951b9) into develop (65dec98) will increase coverage by 0.79%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #29594      +/-   ##
===========================================
+ Coverage    45.70%   46.49%   +0.79%     
===========================================
  Files          687      695       +8     
  Lines        12956    12985      +29     
  Branches      2217     2235      +18     
===========================================
+ Hits          5921     6037     +116     
+ Misses        6717     6623      -94     
- Partials       318      325       +7     
Flag Coverage Δ
e2e 46.46% <ø> (+0.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris marked this pull request as ready for review June 22, 2023 15:14
@dougfabris dougfabris requested review from a team as code owners June 22, 2023 15:14
@ggazzo ggazzo merged commit c197624 into develop Jun 22, 2023
@ggazzo ggazzo deleted the chore/remove-deprecated-GenericTable branch June 22, 2023 17:38
AdityaSingh-02 pushed a commit to AdityaSingh-02/Rocket.Chat that referenced this pull request Jun 24, 2023
@dougfabris dougfabris added this to the 6.3.0 milestone Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants