Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Device Management version info at table and contextual bar #29606

Merged
merged 10 commits into from
Jul 3, 2023

Conversation

hugocostadev
Copy link
Contributor

Proposed changes (including videos or screenshots)

Added version info at Table and Contextual Bar of Admin Device Management page.

The version info stands for Rocket.Chat version of the client being used

Expected:
image

Issue(s)

  1. Open Rocket.Chat
  2. Go to Workspace
  3. Click on Device Management
  4. You should see the second column of the table with the version number
  5. Click the row and you should see the second info being the version number

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Jun 21, 2023

⚠️ No Changeset found

Latest commit: 9e6b1b1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hugocostadev hugocostadev added the squad: Workspace Management squad: Workspace Management label Jun 21, 2023
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #29606 (9e6b1b1) into develop (eecd9fc) will decrease coverage by 15.36%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop   #29606       +/-   ##
============================================
- Coverage    46.65%   31.30%   -15.36%     
============================================
  Files          693      570      -123     
  Lines        12934    10827     -2107     
  Branches      2241     1992      -249     
============================================
- Hits          6035     3389     -2646     
- Misses        6573     7226      +653     
+ Partials       326      212      -114     
Flag Coverage Δ
e2e 31.30% <ø> (-15.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@casalsgh casalsgh requested review from a team and rique223 June 26, 2023 12:44
@hugocostadev hugocostadev requested a review from dougfabris June 26, 2023 17:57
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jun 29, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jun 29, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jun 30, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jul 3, 2023
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Jul 3, 2023
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 3, 2023
@kodiakhq kodiakhq bot merged commit 6493478 into develop Jul 3, 2023
@kodiakhq kodiakhq bot deleted the chore/device-version-column branch July 3, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad: Workspace Management squad: Workspace Management stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants