Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: revert eslint upgrade #29608

Merged
merged 3 commits into from
Jun 21, 2023
Merged

regression: revert eslint upgrade #29608

merged 3 commits into from
Jun 21, 2023

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Jun 21, 2023

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Jun 21, 2023

⚠️ No Changeset found

Latest commit: d589b24

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ggazzo ggazzo changed the title ci: test regression: revert eslint upgrade Jun 21, 2023
@ggazzo ggazzo marked this pull request as ready for review June 21, 2023 19:36
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jun 21, 2023
@ggazzo ggazzo requested review from a team as code owners June 21, 2023 19:36
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #29608 (d589b24) into develop (7f78a29) will decrease coverage by 0.50%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #29608      +/-   ##
===========================================
- Coverage    45.72%   45.23%   -0.50%     
===========================================
  Files          671      693      +22     
  Lines        12598    12888     +290     
  Branches      2228     2230       +2     
===========================================
+ Hits          5761     5830      +69     
- Misses        6510     6747     +237     
+ Partials       327      311      -16     
Flag Coverage Δ
e2e 45.20% <ø> (-0.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Jun 21, 2023
@ggazzo ggazzo merged commit e65933b into develop Jun 21, 2023
@ggazzo ggazzo deleted the ci/eslint branch June 21, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants