Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adjusted to not show 'removed from' notification on Omnichannel rooms #29610

Merged
merged 5 commits into from
Jun 22, 2023

Conversation

aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Jun 21, 2023

Proposed changes (including videos or screenshots)

Issue(s)

OC-1071

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Jun 21, 2023

⚠️ No Changeset found

Latest commit: 91caf83

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@aleksandernsilva aleksandernsilva changed the title fix: Adjusted to not show 'removed from room' notification on omnicha… fix: Adjusted to not show 'removed from' notification on Omnichannel rooms Jun 21, 2023
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #29610 (1b33b61) into develop (f23e4f6) will decrease coverage by 0.85%.
The diff coverage is 25.00%.

❗ Current head 1b33b61 differs from pull request most recent head 91caf83. Consider uploading reports for the commit 91caf83 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #29610      +/-   ##
===========================================
- Coverage    46.46%   45.61%   -0.85%     
===========================================
  Files          698      685      -13     
  Lines        13018    12933      -85     
  Branches      2235     2218      -17     
===========================================
- Hits          6049     5900     -149     
- Misses        6642     6719      +77     
+ Partials       327      314      -13     
Flag Coverage Δ
e2e 45.58% <25.00%> (-0.85%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@aleksandernsilva aleksandernsilva marked this pull request as ready for review June 21, 2023 18:54
@aleksandernsilva aleksandernsilva requested a review from a team as a code owner June 21, 2023 18:54
@aleksandernsilva aleksandernsilva added this to the 6.3.0 milestone Jun 21, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jun 22, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jun 22, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jun 22, 2023
@kodiakhq kodiakhq bot merged commit 0c94802 into develop Jun 22, 2023
@kodiakhq kodiakhq bot deleted the fix/omni-removed-room-msg branch June 22, 2023 17:30
AdityaSingh-02 pushed a commit to AdityaSingh-02/Rocket.Chat that referenced this pull request Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad: omnichannel stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants