Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: Opening the dial pad crashes the GUI #29670

Merged
merged 2 commits into from
Jun 29, 2023
Merged

regression: Opening the dial pad crashes the GUI #29670

merged 2 commits into from
Jun 29, 2023

Conversation

aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Jun 28, 2023

Proposed changes (including videos or screenshots)

Issue(s)

OC-1101
OC-869

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Jun 28, 2023

⚠️ No Changeset found

Latest commit: 99afa60

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@aleksandernsilva aleksandernsilva self-assigned this Jun 28, 2023
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #29670 (99afa60) into develop (6f3eeec) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #29670      +/-   ##
===========================================
+ Coverage    46.64%   46.71%   +0.06%     
===========================================
  Files          692      692              
  Lines        12930    12930              
  Branches      2238     2238              
===========================================
+ Hits          6031     6040       +9     
+ Misses        6575     6568       -7     
+ Partials       324      322       -2     
Flag Coverage Δ
e2e 46.67% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo changed the title fix: Opening the dial pad crashes the GUI regression: Opening the dial pad crashes the GUI Jun 28, 2023
@aleksandernsilva aleksandernsilva marked this pull request as ready for review June 28, 2023 20:53
@aleksandernsilva aleksandernsilva requested a review from a team as a code owner June 28, 2023 20:53
@ggazzo ggazzo merged commit c92b606 into develop Jun 29, 2023
@ggazzo ggazzo deleted the fix/dial-pad branch June 29, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants