-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Case insensitive username #341
Merged
marceloschmidt
merged 1 commit into
RocketChat:master
from
inderpreetsingh:username-bug
Jul 25, 2015
Merged
Case insensitive username #341
marceloschmidt
merged 1 commit into
RocketChat:master
from
inderpreetsingh:username-bug
Jul 25, 2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please also respond to issue #342 |
@rodrigok I think it's ok to merge, so I'm doing it... if you think of any reason why we won't allow uppercase chars, we can revert that. Let us know. |
marceloschmidt
added a commit
that referenced
this pull request
Jul 25, 2015
Case insensitive username
I see no problems with this solution since the user unique verification was changed to be no case sensitive too. |
HappyTobi
pushed a commit
to HappyTobi/Rocket.Chat
that referenced
this pull request
Jul 10, 2018
Fix issues with desktop entry on linux
shubhsherl
pushed a commit
to shubhsherl/Rocket.Chat
that referenced
this pull request
Sep 10, 2020
…on_subscription_handle Push notification subscription handle
This was referenced Dec 14, 2023
This was referenced Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking into open source slack alternatives for a little startup and came across rocket.chat. I deployed it locally and when I tried to signup with username IshwerDAS (that's how we would like to spell it as DAS is actually an acronym). Anyway, it gave me an error. It took me a while to figure out what was wrong as all that error said was
use only letters, numbers, dots and dashes
and that was all I was using. A little look into code made me realize that regex used was only for lower case letters. So now either the error given should have been better or it should accept mixed case usernames. I preferred later and edited code to accept mixed case usernames. But I also didn't want 2 people signing up with same username in different case, so changed the functionusernameIsAvaliable
to be case insensitive when searching.Other solutions could be