Addition to the Stats #5625
Merged
Addition to the Stats #5625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marceloschmidt
requested changes
Jan 24, 2017
server/startup/migrations/v082.js
Outdated
| version: 82, | ||
| up: function() { | ||
| RocketChat.models.Rooms.find().forEach((room) => { | ||
| RocketChat.models.Rooms.incMsgCountById(room._id, RocketChat.models.Messages.find({ rid: room._id, t: { $exists: true }}).count()); |
There was a problem hiding this comment.
Use update and not increment for correctly setting the number of messages.
There was a problem hiding this comment.
Actually after reviewing this, our review together is incorrect as this increments the amount of messages by how many system messages there are.
Closed
23 tasks
|
@marceloschmidt is this PR ok now? |
marceloschmidt
approved these changes
Jan 31, 2017
|
This stats is available in the api? how I can collect data externally? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Done:
Closes #4619