#6270 Adds datetime to default filename on clipboard uploads #6272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
karlprieb
suggested changes
Mar 7, 2017
| @@ -165,7 +166,7 @@ Template.messageBox.events | |||
| e.preventDefault() | |||
| files.push | |||
| file: item.getAsFile() | |||
| name: 'Clipboard' | |||
| name: 'Clipboard - ' + moment().format('L, LTS') | |||
There was a problem hiding this comment.
I think its better use "Time Format" setting instead of hardcode the format here.
Use RocketChat.settings.get('Message_TimeFormat') to get the setting value.
There was a problem hiding this comment.
Hey @karlprieb, thanks for the feedback.
How do you feel about using the Message_TimeAndDateFormat for this? I think it would be better for searching through older files. I'll add a screenshot to the PR.
|
Replaced the hardcoded format for the
|
karlprieb
approved these changes
Mar 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #6270
Added some screenshots to the issue and waiting feedback.