-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Updated icons #188
feat: Updated icons #188
Conversation
8fb7715
to
4dcc1f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the icons cited are used today in the main codebase with these names, but I think all icon names should follow a pattern in order to facilitate usage. Taking that in mind:
edit
should be pencil
add-reaction
should be add-emoji
.
change
should be arrow-change
or arrow-loop
, or atleast start with arrow-
(I think arrow-left-right
would be most suitable)
import
should be arrow-down-box
multiline
should be arrow-return
mobile
should be smartphone
or maybe mobile-device
new-chat
should be pencil-box
post
should be document
queue
could be box-stacked
share
should be arrow-up-box
transfer
should be arrow-right-user
team
should be user-stacked
upload
should be arrow-up-cloud
or maybe upload-cloud
sign-out
should be arrow-right-box
These ones have duplicates:
attachment - file-generic - clip
back - arrow-back - reply-directly
cancel - circle-cross
checkmark-circled - circle-check
circled-arrow-down - circle-arrow-down - download
discover - globe
edit-rounded - new-chat
th-list - sheet - files-sheet
audio - files-audio
add-user - user-plus
jump - jump-to-message - arrow-jump
map-pin - pin-map
files-video - video
files-zip - zip
send-active - send-filled
shield - shield-alt
sort-amount-down - sort
reload - refresh
These do not have a direct name-to-symbol relation, but I didn't find a better name for it
canned-response
live
livechat
new-window
podcast
thread
I triple checked to see if I didn't miss any, but there might be a couple that got overseen.
Addendum: check https://open.rocket.chat/public/icons.html for a list of the icons to be replaced. |
It's okay for me. I just mentioned |
Updates our icon list. Additionally, now we:
glyphsMapping.json
file that guarantees each icon will be uniquely used by the same unicode character across future versions;