Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fixture name not generated from attributed source class #1527

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

RLittlesII
Copy link
Contributor

  • bug: fixture name not generated from attributed source class
  • formatting

@RLittlesII RLittlesII added the 🐞 bug Something isn't working label Dec 2, 2024
@RLittlesII RLittlesII enabled auto-merge (squash) December 2, 2024 04:45
@github-actions github-actions bot added this to the v9.0.2 milestone Dec 2, 2024
Copy link

github-actions bot commented Dec 2, 2024

Summary

Summary
Generated on: 12/02/2024 - 04:51:21
Coverage date: 12/02/2024 - 04:51:20
Parser: Cobertura
Assemblies: 7
Classes: 111
Files: 73
Line coverage: 63.6% (2609 of 4099)
Covered lines: 2609
Uncovered lines: 1490
Coverable lines: 4099
Total lines: 7589
Branch coverage: 68.1% (316 of 464)
Covered branches: 316
Total branches: 464
Method coverage: Feature is only available for sponsors
Tag: 9.0.2-pr1527.15+Branch.pull-1527-merge.Sha.8f069974259da1a903b8a67058732e2cbbc426fe

Coverage

Rocket.Surgery.Extensions.Testing - 94%
Name Line Branch
Rocket.Surgery.Extensions.Testing 94% 72.2%
Rocket.Surgery.Extensions.Testing.DryIocExtensions 100% 75%
Rocket.Surgery.Extensions.Testing.LoggerTest 0%
Rocket.Surgery.Extensions.Testing.LoggerTest 100%
Rocket.Surgery.Extensions.Testing.RocketSurgeonsTestingDefaults 100%
Rocket.Surgery.Extensions.Testing.RocketSurgeryTestContext 0%
Rocket.Surgery.Extensions.Testing.RocketSurgeryTestContext 98.4% 71.4%
Rocket.Surgery.Extensions.Testing.TestBootstrapException 33.3%
Rocket.Surgery.Extensions.Testing.AutoFixtures - 40.4%
Name Line Branch
Rocket.Surgery.Extensions.Testing.AutoFixtures 40.4% 71.7%
Rocket.Surgery.Extensions.Testing.AutoFixtures.Attribute 100%
Rocket.Surgery.Extensions.Testing.AutoFixtures.AutoFixtureGenerator 99.6% 88.1%
Rocket.Surgery.Extensions.Testing.AutoFixtures.AutoFixtureGenerator.Namespa
ceComparer
93.3% 66.6%
Rocket.Surgery.Extensions.Testing.AutoFixtures.AutoFixtureGenerator.Paramet
erReductionComparer
100% 50%
Rocket.Surgery.Extensions.Testing.AutoFixtures.AutoFixtures 100% 50%
Rocket.Surgery.Extensions.Testing.AutoFixtures.Diagnostics 100%
Rocket.Surgery.Extensions.Testing.AutoFixtures.FixtureWithMethods 0%
Rocket.Surgery.Extensions.Testing.AutoFixtures.Methods 54.6% 47.6%
Rocket.Surgery.Extensions.Testing.AutoFixtures.Tests - 100%
Name Line Branch
Rocket.Surgery.Extensions.Testing.AutoFixtures.Tests 100% 100%
Rocket.Surgery.Extensions.Testing.AutoFixtures.Tests.AutoFixtureGeneratorDa
ta
100%
Rocket.Surgery.Extensions.Testing.AutoFixtures.Tests.AutoFixtureSourceData 100%
Rocket.Surgery.Extensions.Testing.AutoFixtures.Tests.DifferentNamedFixtureD
ata
100%
Rocket.Surgery.Extensions.Testing.AutoFixtures.Tests.DuplicateConstructorPa
rameterData
100%
Rocket.Surgery.Extensions.Testing.AutoFixtures.Tests.GenerateMultipleFixtur
esData
100%
Rocket.Surgery.Extensions.Testing.AutoFixtures.Tests.ModuleInitializer 100% 100%
Rocket.Surgery.Extensions.Testing.AutoFixtures.Tests.NestedClassFixtureData 100%
Rocket.Surgery.Extensions.Testing.AutoFixtures.Tests.NonAbstractReferenceTy
peData
100%
Rocket.Surgery.Extensions.Testing.AutoFixtures.Tests.ParameterArraySourceDa
ta
100%
Rocket.Surgery.Extensions.Testing.AutoFixtures.Tests.UsingTypeNamespaceSour
ceData
100%
Rocket.Surgery.Extensions.Testing.AutoFixtures.Tests.ValueTypeSourceData 100%
Rocket.Surgery.Extensions.Testing.Fixtures - 56.6%
Name Line Branch
Rocket.Surgery.Extensions.Testing.Fixtures 56.6% 33.3%
Rocket.Surgery.Extensions.Testing.Fixtures.TestFixtureBuilderExtensions 56.6% 33.3%
Rocket.Surgery.Extensions.Testing.Fixtures.Tests - 100%
Name Line Branch
Rocket.Surgery.Extensions.Testing.Fixtures.Tests 100% ****
Rocket.Surgery.Extensions.Testing.Fixtures.Tests.TestFixture 100%
Rocket.Surgery.Extensions.Testing.Fixtures.Tests.TestFixtureBuilder 100%
Rocket.Surgery.Extensions.Testing.Fixtures.Tests.TestFixtureBuilderExtensio
nTests
100%
Rocket.Surgery.Extensions.Testing.SourceGenerators - 70.4%
Name Line Branch
Rocket.Surgery.Extensions.Testing.SourceGenerators 70.4% 67.4%
Rocket.Surgery.Extensions.Testing.SourceGenerators.AnalyzerTestResult 57.1% 0%
Rocket.Surgery.Extensions.Testing.SourceGenerators.CodeActionTestResult 100%
Rocket.Surgery.Extensions.Testing.SourceGenerators.CodeFixTestResult 100%
Rocket.Surgery.Extensions.Testing.SourceGenerators.CodeMarkup 81% 46.1%
Rocket.Surgery.Extensions.Testing.SourceGenerators.CodeRefactoringTestResul
t
100%
Rocket.Surgery.Extensions.Testing.SourceGenerators.CollectibleTestAssemblyL
oadContext
0%
Rocket.Surgery.Extensions.Testing.SourceGenerators.CompletionItemTestResult 0%
Rocket.Surgery.Extensions.Testing.SourceGenerators.CompletionListTestResult 0%
Rocket.Surgery.Extensions.Testing.SourceGenerators.CompletionTestResult 0%
Rocket.Surgery.Extensions.Testing.SourceGenerators.Customizers 100% 100%
Rocket.Surgery.Extensions.Testing.SourceGenerators.GenerationHelpers 100% 75%
Rocket.Surgery.Extensions.Testing.SourceGenerators.GeneratorAdditionalText 100%
Rocket.Surgery.Extensions.Testing.SourceGenerators.GeneratorTestContext 96.2% 91.6%
Rocket.Surgery.Extensions.Testing.SourceGenerators.GeneratorTestContextBuil
der
89.7% 81.2%
Rocket.Surgery.Extensions.Testing.SourceGenerators.GeneratorTestContextExte
nsions
33.3%
Rocket.Surgery.Extensions.Testing.SourceGenerators.GeneratorTestResult 66.6% 0%
Rocket.Surgery.Extensions.Testing.SourceGenerators.GeneratorTestResults 35.3% 0%
Rocket.Surgery.Extensions.Testing.SourceGenerators.Helpers 100% 100%
Rocket.Surgery.Extensions.Testing.SourceGenerators.MarkedLocation 100%
Rocket.Surgery.Extensions.Testing.SourceGenerators.NamedSourceText 100%
Rocket.Surgery.Extensions.Testing.SourceGenerators.OptionsProvider 55.1% 8.3%
Rocket.Surgery.Extensions.Testing.SourceGenerators.OptionsProvider.OptionsO
bject
100%
Rocket.Surgery.Extensions.Testing.SourceGenerators.ResolvedCodeFixTestResul
t
100%
Rocket.Surgery.Extensions.Testing.SourceGenerators.ResolvedCodeRefactoringT
estResult
100%
Rocket.Surgery.Extensions.Testing.SourceGenerators.TestProjectInformation 100%
Rocket.Surgery.Extensions.Testing.SourceGenerators.VerifyGeneratorTextConte
xt
63.7% 67.7%
Rocket.Surgery.Extensions.Testing.SourceGenerators.VerifyGeneratorTextConte
xt.AdditionalTextConverter
100% 50%
Rocket.Surgery.Extensions.Testing.SourceGenerators.VerifyGeneratorTextConte
xt.AnalyzerTestResultConverter
0%
Rocket.Surgery.Extensions.Testing.SourceGenerators.VerifyGeneratorTextConte
xt.CodeActionConverter
0%
Rocket.Surgery.Extensions.Testing.SourceGenerators.VerifyGeneratorTextConte
xt.CodeActionTestResultConverter
0%
Rocket.Surgery.Extensions.Testing.SourceGenerators.VerifyGeneratorTextConte
xt.CodeFixTestResultConverter
0% 0%
Rocket.Surgery.Extensions.Testing.SourceGenerators.VerifyGeneratorTextConte
xt.CodeRefactoringTestResultConverter
0% 0%
Rocket.Surgery.Extensions.Testing.SourceGenerators.VerifyGeneratorTextConte
xt.CompletionItemTestResultConverter
0%
Rocket.Surgery.Extensions.Testing.SourceGenerators.VerifyGeneratorTextConte
xt.CompletionListTestResultConverter
0%
Rocket.Surgery.Extensions.Testing.SourceGenerators.VerifyGeneratorTextConte
xt.CompletionTestResultConverter
0%
Rocket.Surgery.Extensions.Testing.SourceGenerators.VerifyGeneratorTextConte
xt.DiagnosticConverter
100% 75%
Rocket.Surgery.Extensions.Testing.SourceGenerators.VerifyGeneratorTextConte
xt.GeneratorTestResultConverter
0%
Rocket.Surgery.Extensions.Testing.SourceGenerators.VerifyGeneratorTextConte
xt.LocationConverter
0%
Rocket.Surgery.Extensions.Testing.SourceGenerators.VerifyGeneratorTextConte
xt.ResolvedCodeFixTestResultConverter
0%
Rocket.Surgery.Extensions.Testing.SourceGenerators.VerifyGeneratorTextConte
xt.ResolvedCodeRefactoringTestResultConverter
0% 0%
Rocket.Surgery.Extensions.Testing.SourceGenerators.VerifyGeneratorTextConte
xt.TextChangeConverter
100%
Rocket.Surgery.Extensions.Testing.XUnit.Tests - 93%
Name Line Branch
Rocket.Surgery.Extensions.Testing.XUnit.Tests 93% 75%
Rocket.Surgery.Extensions.Testing.Tests.Generators.GeneratorContextTests 100%
Rocket.Surgery.Extensions.Testing.XUnit.Tests.Fake.AutoFakeEnumerableTests 100%
Rocket.Surgery.Extensions.Testing.XUnit.Tests.Fake.AutoFakeEnumerableTests.
LoggerTest
100%
Rocket.Surgery.Extensions.Testing.XUnit.Tests.Fake.AutoFakePopulateTests 100%
Rocket.Surgery.Extensions.Testing.XUnit.Tests.Fake.AutoFakeTestTests 100%
Rocket.Surgery.Extensions.Testing.XUnit.Tests.Fake.AutoFakeTestTests.Double
Access
100%
Rocket.Surgery.Extensions.Testing.XUnit.Tests.Fake.AutoFakeTestTests.Generi
cLoggerImpl
100%
Rocket.Surgery.Extensions.Testing.XUnit.Tests.Fake.AutoFakeTestTests.Impl 100%
Rocket.Surgery.Extensions.Testing.XUnit.Tests.Fake.AutoFakeTestTests.Logger
FactoryImpl
100%
Rocket.Surgery.Extensions.Testing.XUnit.Tests.Fake.AutoFakeTestTests.Logger
Impl
100%
Rocket.Surgery.Extensions.Testing.XUnit.Tests.Fake.AutoFakeTestTests.Option
al
100%
Rocket.Surgery.Extensions.Testing.XUnit.Tests.Generators.MyDiagnosticGenera
tor
100%
Rocket.Surgery.Extensions.Testing.XUnit.Tests.Generators.MyIncrementalGener
ator
100% 100%
Rocket.Surgery.Extensions.Testing.XUnit.Tests.Generators.MyInputLikeSourceG
enerator
100% 100%
Rocket.Surgery.Extensions.Testing.XUnit.Tests.Generators.MySourceGenerator 100% 100%
Rocket.Surgery.Extensions.Testing.XUnit.Tests.Generators.TestAnalyzer 100% 100%
Rocket.Surgery.Extensions.Testing.XUnit.Tests.Generators.TestCodeFix 50%
Rocket.Surgery.Extensions.Testing.XUnit.Tests.Generators.TestCompletion 0%
Rocket.Surgery.Extensions.Testing.XUnit.Tests.Generators.TestRefactoring 100%
Rocket.Surgery.Extensions.Testing.XUnit.Tests.LoggerTestTests 100% 100%
Rocket.Surgery.Extensions.Testing.XUnit.Tests.LoggerTestTests.Impl 100%
Rocket.Surgery.Extensions.Testing.XUnit.Tests.Mock.AutoMockEnumerableTests 96.6% 50%
Rocket.Surgery.Extensions.Testing.XUnit.Tests.Mock.AutoMockEnumerableTests.
LoggerTest
66.6% 50%
Rocket.Surgery.Extensions.Testing.XUnit.Tests.Mock.AutoMockPopulateTests 100%
Rocket.Surgery.Extensions.Testing.XUnit.Tests.Mock.AutoMockTestTests 100% 100%
Rocket.Surgery.Extensions.Testing.XUnit.Tests.Mock.AutoMockTestTests.Double
Access
100%
Rocket.Surgery.Extensions.Testing.XUnit.Tests.Mock.AutoMockTestTests.Impl 100%
Rocket.Surgery.Extensions.Testing.XUnit.Tests.Mock.AutoMockTestTests.Option
al
100%
Rocket.Surgery.Extensions.Testing.XUnit.Tests.ModuleInitializer 100% 100%
Rocket.Surgery.Extensions.Testing.XUnit.Tests.Substitute.AutoSubstituteEnum
erableTests
76.2% 0%
Rocket.Surgery.Extensions.Testing.XUnit.Tests.Substitute.AutoSubstituteEnum
erableTests.LoggerTest
0% 0%
Rocket.Surgery.Extensions.Testing.XUnit.Tests.Substitute.AutoSubstitutePopu
lateTests
100%
Rocket.Surgery.Extensions.Testing.XUnit.Tests.Substitute.AutoSubstituteTest
Tests
88.5%
Rocket.Surgery.Extensions.Testing.XUnit.Tests.Substitute.AutoSubstituteTest
Tests.DoubleAccess
0%
Rocket.Surgery.Extensions.Testing.XUnit.Tests.Substitute.AutoSubstituteTest
Tests.GenericLoggerImpl
100%
Rocket.Surgery.Extensions.Testing.XUnit.Tests.Substitute.AutoSubstituteTest
Tests.Impl
100%
Rocket.Surgery.Extensions.Testing.XUnit.Tests.Substitute.AutoSubstituteTest
Tests.LoggerFactoryImpl
100%
Rocket.Surgery.Extensions.Testing.XUnit.Tests.Substitute.AutoSubstituteTest
Tests.LoggerImpl
100%
Rocket.Surgery.Extensions.Testing.XUnit.Tests.Substitute.AutoSubstituteTest
Tests.Optional
100%
Rocket.Surgery.Extensions.Testing.XUnit.Tests.XUnitExtensionsTests 100%

Copy link

github-actions bot commented Dec 2, 2024

Test Results

  6 files  ±0    6 suites  ±0   56s ⏱️ -1s
150 tests +4  148 ✅ + 8  2 💤 ±0  0 ❌  - 4 
300 runs  +8  296 ✅ +16  4 💤 ±0  0 ❌  - 8 

Results for commit 6740b34. ± Comparison against base commit b02e9c7.

This pull request removes 4 and adds 8 tests. Note that renamed tests count towards both.
Rocket.Surgery.Extensions.Testing.AutoFixtures.Tests.AutoFixtureGeneratorTests ‑ GivenConstructorWithParameterArray_WhenGenerate_ThenReportsDiagnostic(context: GeneratorTestContext { AssemblyLoadContext = "" Rocket.Surgery.Extensions.Testing.SourceGenerators.CollectibleTestAssemblyLoadContext #32, Id = fQ4yQSlXh1TOo/yArZqC6/HdvP6JVpNCJ0ua7+PMmRI= })
Rocket.Surgery.Extensions.Testing.AutoFixtures.Tests.AutoFixtureGeneratorTests ‑ GivenConstructorWithParameterArray_WhenGenerate_ThenReportsDiagnostic(context: GeneratorTestContext { AssemblyLoadContext = "" Rocket.Surgery.Extensions.Testing.SourceGenerators.CollectibleTestAssemblyLoadContext #33, Id = E14nBPIbYz5LqVrsZaKdTckPNH6hPjp6rakSo9cINgk= })
Rocket.Surgery.Extensions.Testing.AutoFixtures.Tests.AutoFixtureGeneratorTests ‑ GivenNoConstructor_WhenGenerate_ThenReportsDiagnostic(context: GeneratorTestContext { AssemblyLoadContext = "" Rocket.Surgery.Extensions.Testing.SourceGenerators.CollectibleTestAssemblyLoadContext #35, Id = FqeFdR3K8W5mBpIf44OH8Sv9ozau2SYk9XmeWykFCbQ= })
Rocket.Surgery.Extensions.Testing.AutoFixtures.Tests.AutoFixtureGeneratorTests ‑ GivenNoConstructor_WhenGenerate_ThenReportsDiagnostic(context: GeneratorTestContext { AssemblyLoadContext = "" Rocket.Surgery.Extensions.Testing.SourceGenerators.CollectibleTestAssemblyLoadContext #36, Id = bhmW6g0tWplBQItIXoxWojcFHErvE7J+s79eYPshgbA= })
Rocket.Surgery.Extensions.Testing.AutoFixtures.Tests.AutoFixtureGeneratorTests ‑ GivenAutoFixtureAttribute_WhenGenerate_ThenGeneratesAutoFixture(context: GeneratorTestContext { AssemblyLoadContext = "" Rocket.Surgery.Extensions.Testing.SourceGenerators.CollectibleTestAssemblyLoadContext #32, Id = ydtXcMH7lzN0cHPEdUMI/CGLn2nqTTY4Nuq4yiYEQcA= })
Rocket.Surgery.Extensions.Testing.AutoFixtures.Tests.AutoFixtureGeneratorTests ‑ GivenAutoFixtureAttribute_WhenGenerate_ThenGeneratesAutoFixture(context: GeneratorTestContext { AssemblyLoadContext = "" Rocket.Surgery.Extensions.Testing.SourceGenerators.CollectibleTestAssemblyLoadContext #33, Id = Vojm+eX20dC7d84+h5ppbVzo9aEueZFtBX0Fd4iUGS8= })
Rocket.Surgery.Extensions.Testing.AutoFixtures.Tests.AutoFixtureGeneratorTests ‑ GivenAutoFixtureAttribute_WhenGenerate_ThenGeneratesAutoFixture(context: GeneratorTestContext { AssemblyLoadContext = "" Rocket.Surgery.Extensions.Testing.SourceGenerators.CollectibleTestAssemblyLoadContext #34, Id = bbpZ18MRRlZE1b0PIprnJDAB/qattymKXIiOxywXkl0= })
Rocket.Surgery.Extensions.Testing.AutoFixtures.Tests.AutoFixtureGeneratorTests ‑ GivenAutoFixtureAttribute_WhenGenerate_ThenGeneratesAutoFixture(context: GeneratorTestContext { AssemblyLoadContext = "" Rocket.Surgery.Extensions.Testing.SourceGenerators.CollectibleTestAssemblyLoadContext #35, Id = T96xw3FqfaHcHDQ22CfxhcCsyR5/WeP0m++5UaLZe9k= })
Rocket.Surgery.Extensions.Testing.AutoFixtures.Tests.AutoFixtureGeneratorTests ‑ GivenConstructorWithParameterArray_WhenGenerate_ThenReportsDiagnostic(context: GeneratorTestContext { AssemblyLoadContext = "" Rocket.Surgery.Extensions.Testing.SourceGenerators.CollectibleTestAssemblyLoadContext #36, Id = fQ4yQSlXh1TOo/yArZqC6/HdvP6JVpNCJ0ua7+PMmRI= })
Rocket.Surgery.Extensions.Testing.AutoFixtures.Tests.AutoFixtureGeneratorTests ‑ GivenConstructorWithParameterArray_WhenGenerate_ThenReportsDiagnostic(context: GeneratorTestContext { AssemblyLoadContext = "" Rocket.Surgery.Extensions.Testing.SourceGenerators.CollectibleTestAssemblyLoadContext #37, Id = E14nBPIbYz5LqVrsZaKdTckPNH6hPjp6rakSo9cINgk= })
Rocket.Surgery.Extensions.Testing.AutoFixtures.Tests.AutoFixtureGeneratorTests ‑ GivenNoConstructor_WhenGenerate_ThenReportsDiagnostic(context: GeneratorTestContext { AssemblyLoadContext = "" Rocket.Surgery.Extensions.Testing.SourceGenerators.CollectibleTestAssemblyLoadContext #39, Id = FqeFdR3K8W5mBpIf44OH8Sv9ozau2SYk9XmeWykFCbQ= })
Rocket.Surgery.Extensions.Testing.AutoFixtures.Tests.AutoFixtureGeneratorTests ‑ GivenNoConstructor_WhenGenerate_ThenReportsDiagnostic(context: GeneratorTestContext { AssemblyLoadContext = "" Rocket.Surgery.Extensions.Testing.SourceGenerators.CollectibleTestAssemblyLoadContext #40, Id = bhmW6g0tWplBQItIXoxWojcFHErvE7J+s79eYPshgbA= })

@RLittlesII RLittlesII merged commit 36c34c5 into master Dec 2, 2024
7 checks passed
@RLittlesII RLittlesII deleted the autofixture/bug/fixture-name branch December 2, 2024 04:52
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 97.43590% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.03%. Comparing base (b02e9c7) to head (6740b34).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/Testing.AutoFixtures/AutoFixtureGenerator.cs 95.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1527      +/-   ##
==========================================
+ Coverage   62.76%   63.03%   +0.26%     
==========================================
  Files          72       73       +1     
  Lines        3849     3879      +30     
  Branches      150      151       +1     
==========================================
+ Hits         2416     2445      +29     
  Misses       1391     1391              
- Partials       42       43       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants