-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add appveyor CI config #7
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 4 4
Lines 414 414
Branches 82 82
=====================================
Hits 414 414 Continue to review full report at Codecov.
|
but later
See: |
I'm glad you got your build working. And I do think Enlighten needs some testing on Windows, but I think you're missing the goal here. Adding an Appveyor config is pretty easy, the hard part is coming up with relevant tests to run on Windows. Most of the testing involves creating PTYs which is easy on Linux, but the capability was just added to Windows 10 a year ago (It's also in Server 2019). So the options are to make the current tests work by figuring out how to use a similar capability and run the tests on Server 2019 or create a general use test essentially to make sure nothing breaks. Probably both would be good to have in the longer term, though a general use test would be easier to implement in the short term. Perhaps running one of the example scripts would be sufficient. If you're going to work on this, that would be awesome, otherwise I'll add it to my todo list and close this PR. |
Well, I have started with adding working config and it seems that the tests are not passing so I was wondering if you are going to fix them before we would add another test...
|
As explained before, the tests aren't broken, they use lower level Linux calls to create a pseudo terminal. They weren't designed to run on Windows and making them run on Windows is not a minor effort. A basic functionality test would be the place to start rather than trying to run the whole test suite. So if you'd like to tackle that, it would be appreciated, but otherwise I think this request is putting the cart before the horse. |
later also add the badge (using mine just for this branch )
see sample https://github.com/ogrisel/python-appveyor-demo/blob/master/appveyor.yml