Write User logs to AppData folder #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Worth noting that making folders under programfiles user-writable is not generally advisable as it can be used to circumvent application launch protections like AppLocker. May make more sense to instead have this log sit in the user or programdata area. |
|
I think it would be better to have user logs stored elsewhere, as @ITistheworst suggests. Currently, we’ve simply added user permissions to the Update.log to keep things straightforward. |
|
I have now changed everything needed, to write the user logs to the AppData folder, a Symlink to the Intune Log folder will also be created. I hope it suits all like this. %AppData%\Winget-AutoUpdate\Logs |
FaserF
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
As described in #752 it wont work to write user logs since WAU2.0.0, this affected Winget-Install.ps1 runs within the user (seems to work for WAU user runs).
We are now checking on every run, if the folder permissions are correctly set to allow "everyone" to do everything within the logs folder and if the permissions are missing, we are setting it.
Please let me know, if "Install-Prerequisites.ps1" is a good place to check this, or if we should move it somewhere to the WAU installation itself (dont know which file is responsible for this?).
Related Issues
#752