test(core/utils/wechat-mp): fix coverage

Signed-off-by: Rongrong <[email protected]>

lib/setup.test.ts

@@ -185,6 +185,8 @@ var ct = "${1_636_626_300}";
         )
     ),
     http.get(`https://mp.weixin.qq.com/s/rsshub_test_hit_waf`, () => HttpResponse.redirect(`https://mp.weixin.qq.com/mp/rsshub_test/waf`)),
+    http.get(`https://mp.weixin.qq.com/s/rsshub_test_redirect_no_location`, () => HttpResponse.text('', { status: 302 })),
+    http.get(`https://mp.weixin.qq.com/s/rsshub_test_recursive_redirect`, () => HttpResponse.redirect(`https://mp.weixin.qq.com/s/rsshub_test_recursive_redirect`)),
     http.get(`http://rsshub.test/headers`, ({ request }) =>
         HttpResponse.json({
             ...Object.fromEntries(request.headers.entries()),

lib/utils/wechat-mp.test.ts

@@ -1,14 +1,16 @@
-import { describe, expect, it, vi } from 'vitest';
+import { describe, expect, it, vi, afterEach } from 'vitest';
 import { load } from 'cheerio';
 import Parser from 'rss-parser';
 import InvalidParameterError from '@/errors/types/invalid-parameter';
 import { exportedForTestingOnly, WeChatMpError, fetchArticle, finishArticleItem, fixArticleContent, normalizeUrl } from '@/utils/wechat-mp';
-const { ExtractMetadata, showTypeMapReverse } = exportedForTestingOnly;
+const { toggleWerror, ExtractMetadata, showTypeMapReverse } = exportedForTestingOnly;
 
 vi.mock('@/utils/request-rewriter', () => ({ default: null }));
 const { default: app } = await import('@/app');
 const parser = new Parser();
 
+afterEach(() => toggleWerror(false));
+
 const expectedItem: {
     title: string;
     summary: string;
@@ -324,8 +326,20 @@ describe('wechat-mp', () => {
         expect(normalizeUrl(somethingElseWithHash.replace('https://', 'http://'))).toBe(somethingElse);
 
         const notWechatMp = 'https://im.not.wechat.mp/and/an/error/is/expected';
-        expect(() => normalizeUrl(notWechatMp)).toThrow();
+        expect(() => normalizeUrl(notWechatMp)).toThrow('URL host must be "mp.weixin.qq.com"');
         expect(normalizeUrl(notWechatMp, true)).toBe(notWechatMp);
+
+        const unknownSearchParam = mpArticleRoot + '?unknown=param';
+        toggleWerror(false);
+        expect(normalizeUrl(unknownSearchParam)).toBe(unknownSearchParam);
+        toggleWerror(true);
+        expect(() => normalizeUrl(unknownSearchParam)).toThrow('WarningAsError: unknown URL search parameters');
+
+        const unknownPath = mpRoot + '/unknown/path';
+        toggleWerror(false);
+        expect(normalizeUrl(unknownPath)).toBe(unknownPath);
+        toggleWerror(true);
+        expect(() => normalizeUrl(unknownPath, true)).toThrow('WarningAsError: unknown URL path');
     });
 
     it('fetchArticle_&_finishArticleItem_appMsg', async () => {
@@ -413,12 +427,18 @@ describe('wechat-mp', () => {
             expect(error).toBeInstanceOf(WeChatMpError);
             expect((<WeChatMpError>error).message).not.toContain('console.log');
             expect((<WeChatMpError>error).message).not.toContain('.style');
+            expect((<WeChatMpError>error).message).toContain('unknown page');
             expect((<WeChatMpError>error).message).toContain('/mp/rsshub_test/waf');
             expect((<WeChatMpError>error).message).toContain('Title');
             expect((<WeChatMpError>error).message).toContain('环境异常');
         }
     });
 
+    it('redirect', () => {
+        expect(fetchArticle('https://mp.weixin.qq.com/s/rsshub_test_redirect_no_location')).rejects.toThrow('redirect without location');
+        expect(fetchArticle('https://mp.weixin.qq.com/s/rsshub_test_recursive_redirect')).rejects.toThrow('too many redirects');
+    });
+
     it('route_test', async () => {
         try {
             await app.request('/test/wechat-mp');

lib/utils/wechat-mp.ts

@@ -42,10 +42,17 @@ const MAINTAINERS = ['@Rongronggg9'];
 
 const formatLog = (...params: string[]): string => `wechat-mp: ${params.join(': ')}
 Consider raise an issue (mentioning ${MAINTAINERS.join(', ')}) with the article URL for further investigation`;
-const warn = (...params: string[]) => logger.warn(formatLog(...params));
+let warn = (...params: string[]) => logger.warn(formatLog(...params));
 const error = (...params: string[]): never => {
     throw new WeChatMpError(formatLog(...params));
 };
+const toggleWerror = (() => {
+    const onFunc = (...params: string[]) => error('WarningAsError', ...params);
+    const offFunc = warn;
+    return (on: boolean) => {
+        warn = on ? onFunc : offFunc;
+    };
+})();
 
 const replaceReturnNewline = (() => {
     const returnRegExp = /\r|\\(r|x0d)/g;
@@ -612,5 +619,5 @@ const finishArticleItem = async (item, setMpNameAsAuthor = false, skipLink = fal
     return item;
 };
 
-const exportedForTestingOnly = { ExtractMetadata, showTypeMapReverse };
+const exportedForTestingOnly = { toggleWerror, ExtractMetadata, showTypeMapReverse };
 export { exportedForTestingOnly, WeChatMpError, fixArticleContent, fetchArticle, finishArticleItem, normalizeUrl };