Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RK-20520 - Dynatrace reskin + cleanup #386

Closed
wants to merge 36 commits into from
Closed

RK-20520 - Dynatrace reskin + cleanup #386

wants to merge 36 commits into from

Conversation

ron-rookout
Copy link
Contributor

@ron-rookout ron-rookout commented Jun 13, 2024 •
edited
Loading

  1. Reskinned the app to the Dynatrace theme
  2. Removed EULA
  3. Removed unused components and styles
  4. Removed Bugsnag and Segment analytics (ExceptionManager methods have been mostly replaced by a NOOP so we can easily fit a new analytics tool later)
  5. Edited the README

This is what the app looks like now:
image

Tray icon on Mac:
image

@ron-rookout
Removed redundant styles, changed icon and text for empty state
b1220de
@ron-rookout
Changed colors, removed more styles
6d98d95
@ron-rookout
Corrections
a5b0e2b
@ron-rookout
Use Text component
2f289c6
@ron-rookout
Changed app name
3210678
@ron-rookout
Added DT fonts
90e5479
@ron-rookout
Removed unused components
57b2fa1
@ron-rookout
Removed roboto typeface package
9c31286
@ron-rookout
Color changes
707b6d5
@ron-rookout
Style fixes
b823c14
@ron-rookout
Changed close button color
712b6a1
@ron-rookout
Redesign EULA page
983e073
@ron-rookout
Removed redundant class, fixed style instead
78a7436
@ron-rookout
Changed icons
937569b
@ron-rookout
Update dmg-background.png
f0d61c4
@ron-rookout
Removed irrelevant images
ab07736
@ron-rookout
Fixed checkbox style
ef56c77
@ron-rookout
Change copy
2a1868c
@ron-rookout
Removed unused file, changed names
6f96dcb
@ron-rookout
Update deeplinks.ts
33b19a0
@ron-rookout
Readme and text corrections
c4735c7
@ron-rookout
Added images, removed broken links
c26cfc3
@ron-rookout
Merge branch 'master' into dt-reskin
f63efed
@ron-rookout
Merge branch 'master' into dt-reskin
54a38ee
@ron-rookout
Removed redundant dependencies
f906361
@ron-rookout
Change DT related copy and icons
17f6d9d 
This reverts commit f0d61c4.

Change title, revert to old icon

Revert "Changed app name"

This reverts commit 3210678.

Revert "Changed icons"

This reverts commit 937569b.

Revert "Change copy"

This reverts commit 2a1868c.

Revert "Update deeplinks.ts"

This reverts commit 33b19a0.

Revert "Readme and text corrections"

This reverts commit c4735c7.

Revert "Added images, removed broken links"

This reverts commit c26cfc3.
@ron-rookout
Merge branch 'master' into dt-reskin
778b987
@ron-rookout
Merge branch 'master' into dt-reskin
fd8640e
@ron-rookout
Restore DT branding
4efd50a
@ron-rookout
Removed EULA
b05ec90
@ron-rookout
Copy link
Contributor Author

ron-rookout commented Jun 13, 2024 •
edited by jira bot
Loading

Github Enforcer opened Task: RK-20520

@sonariorobot sonariorobot changed the title Dynatrace reskin + cleanup RK-20520 - Dynatrace reskin + cleanup Jun 13, 2024
Urook
Urook reviewed Jun 15, 2024
View reviewed changes
src/exceptionManager.ts Show resolved Hide resolved
webpack.index-worker.config.js Show resolved Hide resolved
@ron-rookout ron-rookout requested a review from Urook June 17, 2024 08:29
Urook
Urook suggested changes Jun 19, 2024
View reviewed changes
package.json
@@ -18,7 +18,7 @@
"debug": "cross-env development=1 $NODE_DEBUG_OPTION yarn run build && cross-env development=1 electron --inspect-brk ./dist/index.js"
},
"build": {
"productName": "Rookout Desktop App",
"productName": "Dynatrace Live Debugging Desktop App",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ron-rookout Update version field

@dan505512
Copy link
Contributor

A quick question:
does this also change the output of the build? Will the files have a different name?
And if so, does that affect the update mechanism? It is actually good for us if the change in the app's name will make it so the app doesn't update automatically from Rookout to Dynatrace

@ron-rookout
Copy link
Contributor Author

A quick question: does this also change the output of the build? Will the files have a different name? And if so, does that affect the update mechanism? It is actually good for us if the change in the app's name will make it so the app doesn't update automatically from Rookout to Dynatrace

Good question, I don't think so, I only changed what seems to be the display name of the app.

@ron-rookout
Copy link
Contributor Author

Irrelevant to this repo, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Urook Urook Urook requested changes

@LiranLast LiranLast Awaiting requested review from LiranLast

@dan505512 dan505512 Awaiting requested review from dan505512

@EliRookout EliRookout Awaiting requested review from EliRookout

@DavidRBiderman DavidRBiderman Awaiting requested review from DavidRBiderman

@FridmasterDyna FridmasterDyna Awaiting requested review from FridmasterDyna

Assignees
No one assigned
Labels
Disable Source Fetching Flows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ron-rookout @dan505512 @Urook