Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TOK-565/votes-allocation-gas-consumption #515

Merged
merged 2 commits into from
Jan 16, 2025
Merged

TOK-565/votes-allocation-gas-consumption #515

merged 2 commits into from
Jan 16, 2025

Conversation

franciscotobar
Copy link
Contributor

@franciscotobar franciscotobar commented Jan 9, 2025 •
edited
Loading

@franciscotobar franciscotobar changed the title refactor: votes allocation TOK-565/votes-allocation-gas-consumption Jan 9, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@franciscotobar franciscotobar force-pushed the TOK-565/votes-allocation-gas-consumption branch 2 times, most recently from 134b05e to becf230 Compare January 10, 2025 03:28
@franciscotobar franciscotobar requested a review from a team January 10, 2025 03:30
@franciscotobar franciscotobar marked this pull request as ready for review January 10, 2025 03:30
@franciscotobar franciscotobar force-pushed the TOK-565/votes-allocation-gas-consumption branch 3 times, most recently from c5b1cb0 to f3cb4d8 Compare January 14, 2025 03:30
jurajpiar
jurajpiar requested changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@jurajpiar jurajpiar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a couple of minor changes I'd do, mostly just refactor though

src/app/collective-rewards/allocations/page.tsx Outdated Show resolved Hide resolved
src/app/collective-rewards/allocations/hooks/useAllocateVotes.test.tsx Outdated Show resolved Hide resolved
src/app/collective-rewards/allocations/hooks/useAllocateVotes.test.tsx Outdated Show resolved Hide resolved
src/app/collective-rewards/allocations/hooks/useAllocateVotes.test.tsx Outdated Show resolved Hide resolved
src/app/collective-rewards/allocations/hooks/useAllocateVotes.test.tsx Outdated Show resolved Hide resolved
src/app/collective-rewards/allocations/context/utils.ts Outdated Show resolved Hide resolved
src/app/collective-rewards/allocations/context/utils.ts Outdated Show resolved Hide resolved
src/app/collective-rewards/allocations/hooks/useAllocateVotes.ts Outdated Show resolved Hide resolved
jurajpiar
jurajpiar approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@jurajpiar jurajpiar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@franciscotobar franciscotobar force-pushed the TOK-565/votes-allocation-gas-consumption branch from 0adf020 to 1d2f457 Compare January 16, 2025 14:32
@franciscotobar franciscotobar merged commit acd1925 into develop Jan 16, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jurajpiar jurajpiar jurajpiar approved these changes

@antomor antomor antomor approved these changes

Assignees
No one assigned
Labels
collective-rewards
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@franciscotobar @antomor @jurajpiar @javicoin