Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TOK-555: format backers reward input field #531

Merged
merged 1 commit into from
Jan 16, 2025
Merged

TOK-555: format backers reward input field #531

merged 1 commit into from
Jan 16, 2025

Conversation

jurajpiar
Copy link
Contributor

  • utilises fully react-number-format lib
  • removes validation with zod as the above renders it "impossible" to enter wrong values

https://rsklabs.atlassian.net/browse/TOK-555

@jurajpiar jurajpiar requested a review from a team January 13, 2025 14:26
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 13, 2025 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@jurajpiar jurajpiar force-pushed the TOK-555/fix_input_field branch from 104326b to 8650f53 Compare January 13, 2025 17:46
franciscotobar
franciscotobar approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@franciscotobar franciscotobar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

antomor
antomor approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@antomor antomor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@franciscotobar franciscotobar merged commit f008464 into develop Jan 16, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franciscotobar franciscotobar franciscotobar approved these changes

@antomor antomor antomor approved these changes

Assignees
No one assigned
Labels
collective-rewards
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jurajpiar @antomor @franciscotobar @javicoin