Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update util.cpp to avoid compiler warning and trow an error if a directory cannot be created. #282

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

andriish
Copy link
Contributor

@andriish andriish commented Feb 13, 2024

Update util.cpp to avoid compiler warning

/source/util.cpp:138:15: warning: ignoring return value of 'int system(const char*)' declared with attribute 'warn_unused_result' [-Wunused-result]
  138 |         system(command_line.c_str());

and trow an error if a directory cannot be created.

Copy link
Member

@lyskov lyskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! - thank you @andriish !

@lyskov lyskov merged commit a7c4388 into RosettaCommons:master Feb 14, 2024
12 checks passed
ldedier-gpfw pushed a commit to G-P-S/binder that referenced this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants