Skip to content

Commit

Permalink
move the stringification to places where they are used, prep to remov…
Browse files Browse the repository at this point in the history
…e the file
  • Loading branch information
Rossmaxx committed Feb 2, 2025
1 parent 10ec2cf commit bf44367
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
1 change: 1 addition & 0 deletions include/Plugin.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
#include "JournallingObject.h"
#include "Model.h"

#define LMMS_STRINGIFY(s) #s // Used to stringify plugin numbers

class QWidget;

Expand Down
4 changes: 3 additions & 1 deletion include/embed.h
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,9 @@
#include <QString>

#include "lmms_export.h"
#include "lmms_basics.h"


#define LMMS_STRINGIFY(s) #s // a macro used to get stringified plugin name

namespace lmms {

Expand Down
2 changes: 0 additions & 2 deletions include/lmms_basics.h
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,6 @@ constexpr char LADSPA_PATH_SEPERATOR =
#endif


#define LMMS_STRINGIFY(s) #s

// Abstract away GUI CTRL key (linux/windows) vs ⌘ (apple)
constexpr const char* UI_CTRL_KEY =
#ifdef LMMS_BUILD_APPLE
Expand Down
3 changes: 1 addition & 2 deletions include/versioninfo.h
Original file line number Diff line number Diff line change
@@ -1,14 +1,13 @@
#ifndef LMMS_VERSION_INFO_H
#define LMMS_VERSION_INFO_H

#include "lmms_basics.h"

#if defined(__GNUC__)
constexpr const char* LMMS_BUILDCONF_COMPILER_VERSION = "GCC " __VERSION__;
#elif defined(__clang__)
constexpr const char* LMMS_BUILDCONF_COMPILER_VERSION = "Clang " __clang_version__;
#elif defined(_MSC_VER)
constexpr const char* LMMS_BUILDCONF_COMPILER_VERSION = "MSVC " LMMS_STRINGIFY(_MSC_FULL_VER);
constexpr const char* LMMS_BUILDCONF_COMPILER_VERSION = "MSVC " _MSC_FULL_VER;
#else
constexpr const char* LMMS_BUILDCONF_COMPILER_VERSION = "unknown compiler";
#endif
Expand Down

0 comments on commit bf44367

Please sign in to comment.